Re: [PATCH 1/2] gnu: librsvg: Generate complete loaders.cache including support for SVG.

[ludo@gnu.org (Ludovic Courtès)]

Federico Beffa <beffa@ieee.org> skribis:

> As mentioned in a previous email, the cache generated by default does
> not include support for SVG provided by librsvg itself.  With this
> patch we generate a full cache file.

Nice.

> From 36c6d59180bdb2d80e169938097efca39431c122 Mon Sep 17 00:00:00 2001
> From: Federico Beffa <beffa@fbengineering.ch>
> Date: Sun, 2 Nov 2014 18:01:08 +0100
> Subject: [PATCH 1/2] gnu: librsvg: Generate complete loaders.cache including
>  support for SVG.
>
> * gnu/packages/gnome.scm (librsvg): Add 'generate-full-chage phase.
                                                         ^^^^^^
Typo.

> +             (system 
> +              (string-append 
> +               "gdk-pixbuf-query-loaders " 
> +               loaders-directory "/libpixbufloader-svg.so "
> +               (fold (lambda (s p) (string-append s " " p))  "" 
> +                     (find-files (assoc-ref inputs "gdk-pixbuf") 
> +                                 "libpixbufloader-.*\\.so"))
> +               "> " loaders-directory ".cache")))))

It may be clearer to replace fold with ‘string-join’

  (string-join (find-files ...))

... in which case the import of (srfi srfi-1) can also be removed.

OK to commit with these changes.

Thanks,
Ludo’.