From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: Re: [PATCH] emacs: Add 'pretty-sha-path'. Date: Thu, 06 Nov 2014 00:38:39 +0300 Message-ID: <8761ettjj4.fsf@gmail.com> References: <87d2926he1.fsf@gmail.com> <87h9ye8x6d.fsf@gnu.org> <87d291uby6.fsf@gmail.com> <874mud4dbb.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:37679) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xm8I0-0000Ty-FE for guix-devel@gnu.org; Wed, 05 Nov 2014 16:39:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xm8Hr-0005Yb-B8 for guix-devel@gnu.org; Wed, 05 Nov 2014 16:38:52 -0500 In-Reply-To: <874mud4dbb.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Wed, 05 Nov 2014 21:12:08 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org Ludovic Court=C3=A8s (2014-11-05 23:12 +0300) wrote: > Alex Kost skribis: > >> Ludovic Court=C3=A8s (2014-11-05 00:37 +0300) wrote: >> >>> Alex Kost skribis: >>> >>>> Also I forgot to mention =E2=80=9Cemacs/guix-messages.el=E2=80=9D in = =E2=80=9Cemacs.am=E2=80=9D in >>>> commit 62f261d, so I did it in this patch (I hope it's not too evil :-= )) >>> >>> Maybe =E2=80=9Cevil=E2=80=9D is too strong a word ;-), but please keep = the >>> emacs/guix-messages.el addition in a separate commit. >>> >>> Commits are cheap and easy, so let=E2=80=99s favor clarity. >> >> Yes, cheap, I know, but not very easy for me as I never sure what to >> write in a commit message and I have to ask guix-devel even about such >> trivial changes (the patch is attached :-)). > > Per =E2=80=98HACKING=E2=80=99 ;-), you don=E2=80=99t *have* to ask for tr= ivial changes. It=E2=80=99s > nice of you to do it, but you don=E2=80=99t have to. Yes, I know, I meant I'm not sure if my commit messages will be appropriate. [...] >> I've realized that "pretty-sha-path" is a bad name, because those 32 >> numbers and letters have nothing to do with SHA-sequences as I thought >> initially. So maybe it would be better to rename it into >> "pretty-hash-path" or "guix-pretty-path" (as it will be a part of Guix) >> or something else. Or is it OK to leave it as it is? > > Good point. Prefixing with =E2=80=98guix-=E2=80=99 makes sense, and it w= ill be easier > for users to find it. > > While we=E2=80=99re at it, =E2=80=9Cpath=E2=80=9D in GNU normally means = =E2=80=9Csearch path=E2=80=9D, not =E2=80=9Cfile > name=E2=80=9D (info "(standards) GNU Manuals"), so perhaps > =E2=80=98guix-pretty-file-names=E2=80=99 or something like that would be = even better. > WDYT? I think =E2=80=98guix-pretty-file-names=E2=80=99 is too long for a package = name as all symbols have to be prefixed with it. What about =E2=80=98guix-prettify=E2= =80=99? --=20 Alex