From: Alex Kost <alezost@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] emacs: Add 'pretty-sha-path'.
Date: Thu, 06 Nov 2014 00:38:39 +0300 [thread overview]
Message-ID: <8761ettjj4.fsf@gmail.com> (raw)
In-Reply-To: <874mud4dbb.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Wed, 05 Nov 2014 21:12:08 +0100")
Ludovic Courtès (2014-11-05 23:12 +0300) wrote:
> Alex Kost <alezost@gmail.com> skribis:
>
>> Ludovic Courtès (2014-11-05 00:37 +0300) wrote:
>>
>>> Alex Kost <alezost@gmail.com> skribis:
>>>
>>>> Also I forgot to mention “emacs/guix-messages.el” in “emacs.am” in
>>>> commit 62f261d, so I did it in this patch (I hope it's not too evil :-))
>>>
>>> Maybe “evil” is too strong a word ;-), but please keep the
>>> emacs/guix-messages.el addition in a separate commit.
>>>
>>> Commits are cheap and easy, so let’s favor clarity.
>>
>> Yes, cheap, I know, but not very easy for me as I never sure what to
>> write in a commit message and I have to ask guix-devel even about such
>> trivial changes (the patch is attached :-)).
>
> Per ‘HACKING’ ;-), you don’t *have* to ask for trivial changes. It’s
> nice of you to do it, but you don’t have to.
Yes, I know, I meant I'm not sure if my commit messages will be
appropriate.
[...]
>> I've realized that "pretty-sha-path" is a bad name, because those 32
>> numbers and letters have nothing to do with SHA-sequences as I thought
>> initially. So maybe it would be better to rename it into
>> "pretty-hash-path" or "guix-pretty-path" (as it will be a part of Guix)
>> or something else. Or is it OK to leave it as it is?
>
> Good point. Prefixing with ‘guix-’ makes sense, and it will be easier
> for users to find it.
>
> While we’re at it, “path” in GNU normally means “search path”, not “file
> name” (info "(standards) GNU Manuals"), so perhaps
> ‘guix-pretty-file-names’ or something like that would be even better.
> WDYT?
I think ‘guix-pretty-file-names’ is too long for a package name as all
symbols have to be prefixed with it. What about ‘guix-prettify’?
--
Alex
next prev parent reply other threads:[~2014-11-05 21:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-04 16:48 [PATCH] emacs: Add 'pretty-sha-path' Alex Kost
2014-11-04 19:39 ` Mark H Weaver
2014-11-05 11:24 ` Alex Kost
2014-11-04 21:37 ` Ludovic Courtès
2014-11-05 11:24 ` Alex Kost
2014-11-05 20:12 ` Ludovic Courtès
2014-11-05 21:38 ` Alex Kost [this message]
2014-11-06 9:37 ` Ludovic Courtès
2014-11-06 13:13 ` [PATCH] emacs: Add 'guix-prettify' Alex Kost
2014-11-06 16:05 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8761ettjj4.fsf@gmail.com \
--to=alezost@gmail.com \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.