all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: 宋文武 <iyzsong@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add desktop-file-utils.
Date: Mon, 02 Feb 2015 18:49:41 +0800	[thread overview]
Message-ID: <8761bkziyi.fsf@gmail.com> (raw)
In-Reply-To: <87fvape31t.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1016 bytes --]

Ludovic Courtès <ludo@gnu.org> writes:

> 宋文武 <iyzsong@gmail.com> skribis:
>
>> * gnu/packages/gnome.scm (desktop-file-utils): New variable.
>
> [...]
>
>> +    (description
>> +     "This package contains a few command line utilities for working with
>> +desktop entries:
>> +
>> +desktop-file-validate: validates a desktop file and prints warnings/errors
>> +                       about desktop entry specification violations.
>> +
>> +desktop-file-install: installs a desktop file to the applications directory,
>> +                      optionally munging it a bit in transit.
>> +
>> +update-desktop-database: updates the database containing a cache of MIME types
>> +                         handled by desktop files.")
>
> Could you remove the alignment of lines (because formatting is lost when
> using the various tools), and enclose the command names in simple
> quotes?
>
> OK to push with that, thanks!
>
> Ludo’.
Sorry, I pushed it already :(

Is this patch OK?

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-desktop-file-utils-Adjust-formatting-of-descript.patch --]
[-- Type: text/x-patch, Size: 1625 bytes --]

From 32c4ff2642fac85fceccb7a009131103049dec92 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E5=AE=8B=E6=96=87=E6=AD=A6?= <iyzsong@gmail.com>
Date: Mon, 2 Feb 2015 18:45:26 +0800
Subject: [PATCH] gnu: desktop-file-utils: Adjust formatting of description.

* gnu/packages/gnome.scm (desktop-file-utils)[description]: Adjust formatting.
---
 gnu/packages/gnome.scm | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index c42092d..b99e332 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -335,14 +335,14 @@ GNOME and KDE desktops to the icon names proposed in the specification.")
      "This package contains a few command line utilities for working with
 desktop entries:
 
-desktop-file-validate: validates a desktop file and prints warnings/errors
-                       about desktop entry specification violations.
+'desktop-file-validate': validates a desktop file and prints warnings/errors
+about desktop entry specification violations.
 
-desktop-file-install: installs a desktop file to the applications directory,
-                      optionally munging it a bit in transit.
+'desktop-file-install': installs a desktop file to the applications directory,
+optionally munging it a bit in transit.
 
-update-desktop-database: updates the database containing a cache of MIME types
-                         handled by desktop files.")
+'update-desktop-database': updates the database containing a cache of MIME types
+handled by desktop files.")
     (license license:gpl2+)))
 
 (define-public gnome-icon-theme
-- 
2.1.2


      reply	other threads:[~2015-02-02 10:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-29 13:09 [PATCH] gnu: Add desktop-file-utils 宋文武
2015-02-01 21:26 ` Ludovic Courtès
2015-02-02 10:49   ` 宋文武 [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8761bkziyi.fsf@gmail.com \
    --to=iyzsong@gmail.com \
    --cc=guix-devel@gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.