From mboxrd@z Thu Jan  1 00:00:00 1970
From: taylanbayirli@gmail.com (Taylan Ulrich =?utf-8?Q?Bay=C4=B1rl=C4=B1?=
	=?utf-8?Q?=2FKammer?=)
Subject: Re: [PATCH] Add guile-emacs!
Date: Tue, 19 May 2015 20:29:34 +0200
Message-ID: <87617ozai9.fsf@T420.taylan>
References: <87r3qo5idm.fsf@earlgrey.lan> <873830f2m0.fsf@earlgrey.lan>
	<87wq0bh70o.fsf@gmail.com> <87oalgear7.fsf@earlgrey.lan>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52492)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <taylanbayirli@gmail.com>) id 1YumGo-0005h1-GV
	for guix-devel@gnu.org; Tue, 19 May 2015 14:29:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <taylanbayirli@gmail.com>) id 1YumGn-0002eW-FS
	for guix-devel@gnu.org; Tue, 19 May 2015 14:29:38 -0400
Received: from mail-wi0-x22b.google.com ([2a00:1450:400c:c05::22b]:37144)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <taylanbayirli@gmail.com>) id 1YumGn-0002eA-9p
	for guix-devel@gnu.org; Tue, 19 May 2015 14:29:37 -0400
Received: by wibt6 with SMTP id t6so33086874wib.0
	for <guix-devel@gnu.org>; Tue, 19 May 2015 11:29:36 -0700 (PDT)
In-Reply-To: <87oalgear7.fsf@earlgrey.lan> (Christopher Allan Webber's message
	of "Tue, 19 May 2015 12:29:17 -0500")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Christopher Allan Webber <cwebber@dustycloud.org>
Cc: Guix-devel <guix-devel@gnu.org>

Christopher Allan Webber <cwebber@dustycloud.org> writes:

> +    (native-inputs
> +     `(("autoconf" ,autoconf)
> +       ("automake" ,automake)
> +       ,@(package-native-inputs emacs)))
> +    (inputs
> +     `(("guile" ,guile-for-guile-emacs)
> +       ,@(package-inputs emacs)))

I didn't think about this before: if Guile is used at compile-time,
e.g. to compile any .scm or .el files, then it should be in native
inputs too.  Can you verify whether it's used or not?  (In the future it
probably will be used to compile .el files, but that's still not enabled
if I remember correctly.)

> +    (arguments
> +     (substitute-keyword-arguments `(;; Build fails if we allow parallel build
> +                                     #:parallel-build? #f

Stylistic nitpick: sentence in comment should end with a period.

> +    (native-inputs
> +     `(("autoconf" ,autoconf)
> +       ("automake" ,automake)
> +       ("libtool" ,libtool)
> +       ("flex" ,flex)
> +       ("texinfo" ,texinfo)
> +       ,@(package-native-inputs guile-2.0)))
> +    (inputs
> +     `(("gettext" ,gnu-gettext)
> +       ,@(package-inputs guile-2.0)))))

I think we wanted to put Gettext in native-inputs?


I'd say OK to push with those changes, thanks! :-)

Taylan