From: taylanbayirli@gmail.com (Taylan Ulrich Bayırlı/Kammer)
To: Christopher Allan Webber <cwebber@dustycloud.org>
Cc: Guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] Add guile-emacs!
Date: Tue, 19 May 2015 20:29:34 +0200 [thread overview]
Message-ID: <87617ozai9.fsf@T420.taylan> (raw)
In-Reply-To: <87oalgear7.fsf@earlgrey.lan> (Christopher Allan Webber's message of "Tue, 19 May 2015 12:29:17 -0500")
Christopher Allan Webber <cwebber@dustycloud.org> writes:
> + (native-inputs
> + `(("autoconf" ,autoconf)
> + ("automake" ,automake)
> + ,@(package-native-inputs emacs)))
> + (inputs
> + `(("guile" ,guile-for-guile-emacs)
> + ,@(package-inputs emacs)))
I didn't think about this before: if Guile is used at compile-time,
e.g. to compile any .scm or .el files, then it should be in native
inputs too. Can you verify whether it's used or not? (In the future it
probably will be used to compile .el files, but that's still not enabled
if I remember correctly.)
> + (arguments
> + (substitute-keyword-arguments `(;; Build fails if we allow parallel build
> + #:parallel-build? #f
Stylistic nitpick: sentence in comment should end with a period.
> + (native-inputs
> + `(("autoconf" ,autoconf)
> + ("automake" ,automake)
> + ("libtool" ,libtool)
> + ("flex" ,flex)
> + ("texinfo" ,texinfo)
> + ,@(package-native-inputs guile-2.0)))
> + (inputs
> + `(("gettext" ,gnu-gettext)
> + ,@(package-inputs guile-2.0)))))
I think we wanted to put Gettext in native-inputs?
I'd say OK to push with those changes, thanks! :-)
Taylan
next prev parent reply other threads:[~2015-05-19 18:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-10 19:35 [PATCH] Attempt at packaging guile-emacs (needs help) Christopher Allan Webber
2015-05-10 21:51 ` Mark H Weaver
2015-05-11 2:29 ` Christopher Allan Webber
2015-05-14 0:01 ` [PATCH] Add guile-emacs! Christopher Allan Webber
2015-05-14 8:56 ` Taylan Ulrich Kammer
2015-05-14 15:53 ` Christopher Allan Webber
2015-05-14 20:06 ` Taylan Ulrich Kammer
2015-05-14 20:52 ` Taylan Ulrich Kammer
2015-05-15 10:13 ` Ludovic Courtès
2015-05-19 17:29 ` Christopher Allan Webber
2015-05-19 18:29 ` Taylan Ulrich Bayırlı/Kammer [this message]
2015-05-19 19:41 ` Christopher Allan Webber
2015-05-19 20:24 ` Taylan Ulrich Bayırlı/Kammer
2015-05-20 12:22 ` Ludovic Courtès
2015-05-23 7:26 ` Feng Shu
2015-05-23 17:21 ` Christopher Allan Webber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87617ozai9.fsf@T420.taylan \
--to=taylanbayirli@gmail.com \
--cc=cwebber@dustycloud.org \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.