From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark H Weaver Subject: Re: [PATCH 2/2] gnu: libxml2: Build python bindings separately. Date: Sun, 31 May 2015 12:57:12 -0400 Message-ID: <876178vg5z.fsf@netris.org> References: <1432977172-14658-1-git-send-email-iyzsong@gmail.com> <1432977172-14658-2-git-send-email-iyzsong@gmail.com> <87d21iuk0r.fsf@netris.org> <87d21hlbsu.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:46578) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yz6YJ-0002eS-NQ for guix-devel@gnu.org; Sun, 31 May 2015 12:57:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yz6YF-0007XP-Ka for guix-devel@gnu.org; Sun, 31 May 2015 12:57:35 -0400 Received: from world.peace.net ([50.252.239.5]:54809) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yz6YF-0007UV-Gr for guix-devel@gnu.org; Sun, 31 May 2015 12:57:31 -0400 In-Reply-To: <87d21hlbsu.fsf@gmail.com> (=?utf-8?B?IuWui+aWh+atpiIncw==?= message of "Sun, 31 May 2015 10:29:21 +0800") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: =?utf-8?B?5a6L5paH5q2m?= Cc: guix-devel@gnu.org =E5=AE=8B=E6=96=87=E6=AD=A6 writes: > Mark H Weaver writes: > >> =E5=AE=8B=E6=96=87=E6=AD=A6 writes: >> >>> * gnu/packages/xml.scm (libxml2)[native-inputs]: Remove python. >>> [arguments]: Remove. >>> (python-libxml2, python2-libxml): New variables. >>> --- >>> gnu/packages/xml.scm | 53 ++++++++++++++++++++++++++++++--------------= -------- >>> 1 file changed, 31 insertions(+), 22 deletions(-) >>> >>> diff --git a/gnu/packages/xml.scm b/gnu/packages/xml.scm >>> index a4c81b2..22d4e52 100644 >>> --- a/gnu/packages/xml.scm >>> +++ b/gnu/packages/xml.scm >> >> [...] >> >>> +(define-public python2-libxml >>> + (package-with-python2 python-libxml2)) >>> + >> >> Due to non-obvious complications arising from the fact that xml.scm and >> python.scm are mutually dependent on each other, we can't use >> 'package-with-python2' from xml.scm. For now, I suggest moving it to >> python.scm, where all other uses of 'package-with-python2' are currently >> located. >> >> For an explanation, see: >> >> https://lists.gnu.org/archive/html/guix-devel/2014-12/msg00355.html > Thanks for explainging, but when I put it into python.scm, > I got "Unbound variable: libxml2" when running: > $ ./pre-inst-env guix package -i python2-libxml > or: > $ make > but not: > $ ./pre-inst-env guix build python2-libxml > > Any ideas? Thanks! It turns out that 'package-with-python2' is no longer exported from (gnu packages python), but rather from (guix build-system python) which is not part of any cycles, so it is now okay to use 'package-with-python2' from other modules. In fact, because of the (inherit libxml2) in 'python-libxml2', these packages should be in xml.scm, right where you had put them -- or at least not in any other module that shares a cycle with xml.scm -- so please disregard my suggestion that they should be moved. However, I just noticed one minor mispelling: the variable should be named 'python2-libxml2', not 'python2-libxml'. Thanks! Mark