all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Leo Famulari <leo@famulari.name>
Cc: 21280@debbugs.gnu.org
Subject: bug#21280: test failures: nar, syscalls, containers
Date: Thu, 20 Aug 2015 01:14:03 +0200	[thread overview]
Message-ID: <87614a50sk.fsf@gnu.org> (raw)
In-Reply-To: <1439949357.1343604.359857913.0408A579@webmail.messagingengine.com> (Leo Famulari's message of "Tue, 18 Aug 2015 21:55:57 -0400")

[-- Attachment #1: Type: text/plain, Size: 795 bytes --]

Leo Famulari <leo@famulari.name> skribis:

> On Tue, Aug 18, 2015, at 17:54, Ludovic Courtès wrote:
>> What is the file system of /home/leo/work/guix (see the output of the
>> ‘mount’ command)?
>
> $ mount
> [...]
> /dev/mapper/hostname--vg-home on /home type btrfs (rw,relatime,space_cache)
> [...]

OK.

>> and then run “make check TESTS=tests/nar.scm” from the top-level build
>> directory, and post both the top-level ‘nar.log’ file and
>> ‘tests/nar.log’?
>
> The logs are attached. I renamed tests/nar.log to tests-nar.log.

Hmm the output of ‘find’ in tests/nar.log suggests that the files are
indeed identical, so maybe it’s ‘file-tree-equal?’ that’s not working as
expected.

Could you try this patch and send tests/nar.log again?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 1052 bytes --]

diff --git a/tests/nar.scm b/tests/nar.scm
index b8e50c7..37a357b 100644
--- a/tests/nar.scm
+++ b/tests/nar.scm
@@ -112,7 +112,8 @@
   (file-system-fold (const #t)
                     (lambda (name stat result)    ; leaf
                       (and result
-                           (file=? name (sibling name))))
+                           (pk 'file=? name (sibling name)
+                               (file=? name (sibling name)))))
                     (lambda (name stat result)    ; down
                       result)
                     (lambda (name stat result)    ; up

diff --git a/guix/tests.scm b/guix/tests.scm
index cd8eda2..efa1a6f 100644
--- a/guix/tests.scm
+++ b/guix/tests.scm
@@ -101,7 +101,8 @@
 
 (define (file=? a b)
   "Return true if files A and B have the same type and same content."
-  (and (eq? (stat:type (lstat a)) (stat:type (lstat b)))
+  (and (eq? (pk 'stat a  (stat:type (lstat a)))
+            (pk 'stat2 b (stat:type (lstat b))))
        (case (stat:type (lstat a))
          ((regular)
           (equal?

[-- Attachment #3: Type: text/plain, Size: 32 bytes --]


Thanks in advance,
Ludo’.

  reply	other threads:[~2015-08-19 23:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-17  3:43 bug#21280: test failures: nar, syscalls, containers Leo Famulari
2015-08-17 15:42 ` Thompson, David
2015-08-18  3:00   ` Leo Famulari
2015-08-18 21:54 ` Ludovic Courtès
2015-08-19  1:55   ` Leo Famulari
2015-08-19 23:14     ` Ludovic Courtès [this message]
2015-08-20  4:14       ` Leo Famulari
2015-08-20 10:02         ` Ludovic Courtès
     [not found]           ` <1440109544.937009.361720705.14632458@webmail.messagingengine.com>
2015-08-24 22:07             ` Ludovic Courtès
2015-08-25 17:38               ` Leo Famulari
2015-08-25 22:44                 ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87614a50sk.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=21280@debbugs.gnu.org \
    --cc=leo@famulari.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.