From: ludo@gnu.org (Ludovic Courtès)
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: Guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] Add ggplot2.
Date: Tue, 01 Sep 2015 23:26:02 +0200 [thread overview]
Message-ID: <87613tesr9.fsf@gnu.org> (raw)
In-Reply-To: <idjzj178t4g.fsf@bimsb-sys02.mdc-berlin.net> (Ricardo Wurmus's message of "Mon, 31 Aug 2015 15:50:07 +0200")
Howdy Ricardo!
Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:
> while writing the r-build-system and the CRAN importer I tested it by
> packaging ggplot2 with all dependencies. 16 patches are attached; all
> of them are very simple (this bodes well for the future of R on Guix).
Indeed, that’s a really good sign.
> To make sure ggplot2 actually works I did this:
>
> guix package -p ~/r-tests -i r r-ggplot2
> export R_LIBS_SITE="$HOME/r-tests/site-library/"
> ~/r-tests/bin/R
>
> > data(iris)
> > library(ggplot2)
> > ggplot(iris,aes(Sepal.Length,Sepal.Width)) + geom_point()
>
> (produces a scatter plot.)
Neat.
I look at the patches briefly and don’t have anything to say. Perhaps
the only thing that might be worth checking is whether license info is
usually accurate, but I suppose pretty much all R packages are GPLv3+ in
practice since that’s what R is under?
So maybe just double-check, change the licenses to GPLv3+, and push.
Thank you,
Ludo’.
prev parent reply other threads:[~2015-09-01 21:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-31 13:50 [PATCH] Add ggplot2 Ricardo Wurmus
2015-09-01 21:26 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87613tesr9.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=ricardo.wurmus@mdc-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.