From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCHES] Whip polkit into shape Date: Wed, 02 Sep 2015 21:18:34 +0200 Message-ID: <87613s7hpx.fsf@gnu.org> References: <874mjetlfy.fsf@igalia.com> <87zj16s6d8.fsf@igalia.com> <87vbbus679.fsf@igalia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:48526) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXDYO-0007JB-Ed for guix-devel@gnu.org; Wed, 02 Sep 2015 15:18:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZXDYL-0008I6-4a for guix-devel@gnu.org; Wed, 02 Sep 2015 15:18:40 -0400 In-Reply-To: <87vbbus679.fsf@igalia.com> (Andy Wingo's message of "Tue, 01 Sep 2015 13:57:14 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Andy Wingo Cc: guix-devel@gnu.org Andy Wingo skribis: > On Tue 01 Sep 2015 13:53, Andy Wingo writes: > >> Attached are three patches to polkit. The first makes polkit use >> elogind for seat management. The second is based on a WIP patch from >> Mark, and arranges for polkit to look in the system profile for rules >> and actions. The third adds a polkit service. I've tested these by >> running "pkaction" and "pkcheck", both with an embedded authentication >> agent and with an external agent. Kinda cool to see these work. >> Unfortunately I haven't gotten user-mode "loginctl reboot" to work -- >> for some reason it doesn't end up spawning the authentication agent >> correctly. Oh well, future work. Usually people will be running with a >> authentication agent linked to their graphical session anyway. OK, sounds like it=E2=80=99s getting there! :-) > From e409449f493da3a42b9f989c819d3290fe9a523a Mon Sep 17 00:00:00 2001 > From: Andy Wingo > Date: Tue, 18 Aug 2015 11:39:22 +0200 > Subject: [PATCH 3/7] gnu: polkit: Use elogind for seat management. > > * gnu/packages/polkit.scm (polkit): Depend on elogind. OK. Could you add a copyright line? > From 11e1301553117f093642142bf50bb4462c87ba47 Mon Sep 17 00:00:00 2001 > From: Andy Wingo > Date: Tue, 1 Sep 2015 13:30:31 +0200 > Subject: [PATCH 4/7] gnu: polkit: Look for rules in > /run/current-system/profile. > > * gnu/packages/polkit.scm (polkit): Configure to look for actions and > rules in the system profile. Arrange to look for the setuid helper in > /run/setuid-programs. Fix introspection installation. I have a preference to the =E2=80=98dbus-service=E2=80=99 style, where we p= ass the exact list of services to the service function, because it makes things explicit and transparent. But I=E2=80=99m fine with using this approach now and maybe revisiting it l= ater. > +;;; Copyright =C2=A9 2015 Mark H Weaver Add yourself too? > From ec20ffc9bdad2d467ec0f7e76f1b7f7a92580eff Mon Sep 17 00:00:00 2001 > From: Andy Wingo > Date: Tue, 18 Aug 2015 11:57:15 +0200 > Subject: [PATCH 5/7] gnu: Add polkit service. > > * gnu/services/desktop.scm (polkit-service): New function. > (%desktop-services): Add polkit service. Could you add it to guix.texi? Otherwise LGTM. Thanks! Ludo=E2=80=99.