From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] Gracefully handle incompatible locale data
Date: Tue, 27 Oct 2015 16:57:03 +0100
Message-ID: <87611sticw.fsf@gnu.org>
References: <876132lbic.fsf@gnu.org>
	<20151027153037.GB2483@var.bordeaux.inria.fr>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58045)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Zr6cY-0007l9-OL
	for guix-devel@gnu.org; Tue, 27 Oct 2015 11:57:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Zr6cX-0007PA-KK
	for guix-devel@gnu.org; Tue, 27 Oct 2015 11:57:10 -0400
In-Reply-To: <20151027153037.GB2483@var.bordeaux.inria.fr> (Samuel Thibault's
	message of "Tue, 27 Oct 2015 16:30:37 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Samuel Thibault <samuel.thibault@gnu.org>
Cc: guix-devel@gnu.org

Samuel Thibault <samuel.thibault@gnu.org> skribis:

> Ludovic Court=C3=A8s, le Tue 22 Sep 2015 17:27:55 +0200, a =C3=A9crit :
>>   loadlocale.c:130: _nl_intern_locale_data: Assertion `cnt < (sizeof (_n=
l_value_type_LC_COLLATE) / sizeof (_nl_value_type_LC_COLLATE[0]))' failed.
>>=20
>> This patch changes such conditions to return EINVAL instead of aborting.
>
> Just like it does for the __glibc_unlikely (idx > (size_t)
> newdata->filesize) test above, so it doesn't actually introduce any new
> error condition.
>
> I thus commited the change, thanks!

Thank you!  :-)

Ludo=E2=80=99.