[PATCH 3/3] emacs: Disable minor modes in 'guix-build-log-mode'.

[PATCH 3/3] emacs: Disable minor modes in 'guix-build-log-mode'.

[Alex Kost]

[-- Attachment #1: Type: text/plain, Size: 306 bytes --]

Initially I thought it's a good idea to enable
'compilation-shell-minor-mode' and 'view-mode' in 'guix-build-log-mode'
by default, but it is probably not, because:

- 'compilation-shell-minor-mode' is very slow on big buffers;
- 'view-mode' binds "c" key which I'd like to bind to the compilation
  mode.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0003-emacs-Disable-minor-modes-in-guix-build-log-mode.patch --]
[-- Type: text/x-patch, Size: 1556 bytes --]

From 4d13ab2a470b39dffa2e3a4c086a6f7237485777 Mon Sep 17 00:00:00 2001
From: Alex Kost <alezost@gmail.com>
Date: Thu, 29 Oct 2015 21:05:17 +0300
Subject: [PATCH 3/3] emacs: Disable minor modes in 'guix-build-log-mode'.

* emacs/guix-build-log.el (guix-build-log-mode-hook): Remove
  'compilation-shell-minor-mode' as it is slow on big buffers, and
  'view-mode' as it rebinds too many keys.
  (guix-build-log-mode-map): Add "c" and "v" key bindings for the
  removed minor modes.
---
 emacs/guix-build-log.el | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/emacs/guix-build-log.el b/emacs/guix-build-log.el
index 1242607..c43c236 100644
--- a/emacs/guix-build-log.el
+++ b/emacs/guix-build-log.el
@@ -102,10 +102,7 @@
   "Face for the number of seconds for a phase."
   :group 'guix-build-log-faces)
 
-(defcustom guix-build-log-mode-hook
-  ;; Not using `compilation-minor-mode' because it rebinds some standard
-  ;; keys, including M-n/M-p.
-  '(compilation-shell-minor-mode view-mode)
+(defcustom guix-build-log-mode-hook '()
   "Hook run after `guix-build-log-mode' is entered."
   :type 'hook
   :group 'guix-build-log)
@@ -196,6 +193,8 @@ For `guix-build-log-minor-mode' this map is prefixed with 'C-c'.")
     (set-keymap-parent
      map (make-composed-keymap (list guix-build-log-common-map)
                                special-mode-map))
+    (define-key map (kbd "c") 'compilation-shell-minor-mode)
+    (define-key map (kbd "v") 'view-mode)
     map)
   "Keymap for `guix-build-log-mode' buffers.")
 
-- 
2.5.0

Re: [PATCH 3/3] emacs: Disable minor modes in 'guix-build-log-mode'.

[Ludovic Courtès]

Alex Kost <alezost@gmail.com> skribis:

> From 4d13ab2a470b39dffa2e3a4c086a6f7237485777 Mon Sep 17 00:00:00 2001
> From: Alex Kost <alezost@gmail.com>
> Date: Thu, 29 Oct 2015 21:05:17 +0300
> Subject: [PATCH 3/3] emacs: Disable minor modes in 'guix-build-log-mode'.
>
> * emacs/guix-build-log.el (guix-build-log-mode-hook): Remove
>   'compilation-shell-minor-mode' as it is slow on big buffers, and
>   'view-mode' as it rebinds too many keys.
>   (guix-build-log-mode-map): Add "c" and "v" key bindings for the
>   removed minor modes.

OK.

Thanks!

Ludo’.