From: Alex Kost <alezost@gmail.com>
To: guix-devel@gnu.org
Subject: [PATCH 3/3] emacs: Disable minor modes in 'guix-build-log-mode'.
Date: Thu, 29 Oct 2015 23:33:32 +0300 [thread overview]
Message-ID: <87611pza77.fsf@gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 306 bytes --]
Initially I thought it's a good idea to enable
'compilation-shell-minor-mode' and 'view-mode' in 'guix-build-log-mode'
by default, but it is probably not, because:
- 'compilation-shell-minor-mode' is very slow on big buffers;
- 'view-mode' binds "c" key which I'd like to bind to the compilation
mode.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0003-emacs-Disable-minor-modes-in-guix-build-log-mode.patch --]
[-- Type: text/x-patch, Size: 1556 bytes --]
From 4d13ab2a470b39dffa2e3a4c086a6f7237485777 Mon Sep 17 00:00:00 2001
From: Alex Kost <alezost@gmail.com>
Date: Thu, 29 Oct 2015 21:05:17 +0300
Subject: [PATCH 3/3] emacs: Disable minor modes in 'guix-build-log-mode'.
* emacs/guix-build-log.el (guix-build-log-mode-hook): Remove
'compilation-shell-minor-mode' as it is slow on big buffers, and
'view-mode' as it rebinds too many keys.
(guix-build-log-mode-map): Add "c" and "v" key bindings for the
removed minor modes.
---
emacs/guix-build-log.el | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/emacs/guix-build-log.el b/emacs/guix-build-log.el
index 1242607..c43c236 100644
--- a/emacs/guix-build-log.el
+++ b/emacs/guix-build-log.el
@@ -102,10 +102,7 @@
"Face for the number of seconds for a phase."
:group 'guix-build-log-faces)
-(defcustom guix-build-log-mode-hook
- ;; Not using `compilation-minor-mode' because it rebinds some standard
- ;; keys, including M-n/M-p.
- '(compilation-shell-minor-mode view-mode)
+(defcustom guix-build-log-mode-hook '()
"Hook run after `guix-build-log-mode' is entered."
:type 'hook
:group 'guix-build-log)
@@ -196,6 +193,8 @@ For `guix-build-log-minor-mode' this map is prefixed with 'C-c'.")
(set-keymap-parent
map (make-composed-keymap (list guix-build-log-common-map)
special-mode-map))
+ (define-key map (kbd "c") 'compilation-shell-minor-mode)
+ (define-key map (kbd "v") 'view-mode)
map)
"Keymap for `guix-build-log-mode' buffers.")
--
2.5.0
next reply other threads:[~2015-10-29 20:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-29 20:33 Alex Kost [this message]
2015-10-30 16:53 ` [PATCH 3/3] emacs: Disable minor modes in 'guix-build-log-mode' Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87611pza77.fsf@gmail.com \
--to=alezost@gmail.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.