From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 2/2] gnu: Add owncloud-client.
Date: Thu, 05 Nov 2015 22:32:21 +0100
Message-ID: <87611gceu2.fsf@gnu.org>
References: <1446497399-30726-1-git-send-email-efraim@flashner.co.il>
	<1446497399-30726-3-git-send-email-efraim@flashner.co.il>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47930)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZuS8x-0004IE-N9
	for guix-devel@gnu.org; Thu, 05 Nov 2015 16:32:28 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZuS8t-0007Rd-LM
	for guix-devel@gnu.org; Thu, 05 Nov 2015 16:32:27 -0500
In-Reply-To: <1446497399-30726-3-git-send-email-efraim@flashner.co.il> (Efraim
	Flashner's message of "Mon, 2 Nov 2015 22:49:59 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Efraim Flashner <efraim@flashner.co.il>
Cc: guix-devel@gnu.org

Efraim Flashner <efraim@flashner.co.il> skribis:

> * gnu/packages/owncloud.scm (owncloud-client): New variable.
> * gnu-system.am [GNU_SYSTEM_MODULES]: Add it.

[...]

> +       (modify-phases %standard-phases
> +        (add-after 'unpack 'change-rpath-dirs
> +          (lambda _
> +           (substitute* '("src/libsync/CMakeLists.txt"
> +                          "csync/src/CMakeLists.txt")
> +                         (("\\/\\$\\{APPLICATION_EXECUTABLE\\}") ""))
> +           (substitute* '("src/cmd/CMakeLists.txt"
> +                          "src/crashreporter/CMakeLists.txt"
> +                          "src/gui/CMakeLists.txt")
> +                         (("\\/\\$\\{APPLICATION_EXECUTABLE\\}\\\"") "\"=
")))))))

Please indent as in other files.  Also, could you add a comment
explaining what this does?

> +    (synopsis "GUI folder synchronization with an ownCloud server")

I=E2=80=99d remove =E2=80=9CGUI=E2=80=9D here (looks weird.)

> +    (description "The ownCloudSync system lets you always have your late=
st

=E2=80=A6 and s/system/GUI/ here.

Could you send an updated patch?

Thanks,
Ludo=E2=80=99.