all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Efraim Flashner <efraim@flashner.co.il>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 2/2] gnu: Add owncloud-client.
Date: Thu, 05 Nov 2015 22:32:21 +0100	[thread overview]
Message-ID: <87611gceu2.fsf@gnu.org> (raw)
In-Reply-To: <1446497399-30726-3-git-send-email-efraim@flashner.co.il> (Efraim Flashner's message of "Mon, 2 Nov 2015 22:49:59 +0200")

Efraim Flashner <efraim@flashner.co.il> skribis:

> * gnu/packages/owncloud.scm (owncloud-client): New variable.
> * gnu-system.am [GNU_SYSTEM_MODULES]: Add it.

[...]

> +       (modify-phases %standard-phases
> +        (add-after 'unpack 'change-rpath-dirs
> +          (lambda _
> +           (substitute* '("src/libsync/CMakeLists.txt"
> +                          "csync/src/CMakeLists.txt")
> +                         (("\\/\\$\\{APPLICATION_EXECUTABLE\\}") ""))
> +           (substitute* '("src/cmd/CMakeLists.txt"
> +                          "src/crashreporter/CMakeLists.txt"
> +                          "src/gui/CMakeLists.txt")
> +                         (("\\/\\$\\{APPLICATION_EXECUTABLE\\}\\\"") "\"")))))))

Please indent as in other files.  Also, could you add a comment
explaining what this does?

> +    (synopsis "GUI folder synchronization with an ownCloud server")

I’d remove “GUI” here (looks weird.)

> +    (description "The ownCloudSync system lets you always have your latest

… and s/system/GUI/ here.

Could you send an updated patch?

Thanks,
Ludo’.

  reply	other threads:[~2015-11-05 21:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-02 20:49 [PATCH 0/2] Owncloud-client Efraim Flashner
2015-11-02 20:49 ` [PATCH 1/2] gnu: Add qtkeychain Efraim Flashner
2015-11-05 21:28   ` Ludovic Courtès
2015-11-07 18:31     ` Efraim Flashner
2015-11-08  6:17       ` Efraim Flashner
2015-11-10 18:07       ` Ludovic Courtès
2015-11-12 12:22         ` Efraim Flashner
2015-11-12 13:03           ` Ludovic Courtès
2015-11-02 20:49 ` [PATCH 2/2] gnu: Add owncloud-client Efraim Flashner
2015-11-05 21:32   ` Ludovic Courtès [this message]
2015-11-07 18:35     ` Efraim Flashner
2015-11-10 18:02       ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87611gceu2.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=efraim@flashner.co.il \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.