From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roel Janssen Subject: Re: [PATCH] Add libconfig. Date: Thu, 10 Dec 2015 16:20:51 +0100 Message-ID: <876106ba98.fsf@gnu.org> References: <878u52be92.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:48524) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a730b-0002or-FL for guix-devel@gnu.org; Thu, 10 Dec 2015 10:19:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a730X-0003Wa-CF for guix-devel@gnu.org; Thu, 10 Dec 2015 10:19:53 -0500 In-reply-to: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ricardo Wurmus Cc: guix-devel@gnu.org --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-gnu-Add-libconfig-v2.patch >From 72e065fc7c8012508ee8ac2963ac25a7c173d33f Mon Sep 17 00:00:00 2001 From: Roel Janssen Date: Thu, 10 Dec 2015 16:15:04 +0100 Subject: [PATCH] gnu: Add libconfig. * gnu/packages/textutils.scm (libconfig): New variable. --- gnu/packages/textutils.scm | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/gnu/packages/textutils.scm b/gnu/packages/textutils.scm index e020290..2aa8615 100644 --- a/gnu/packages/textutils.scm +++ b/gnu/packages/textutils.scm @@ -179,3 +179,25 @@ the Hannon Lab.") "CityHash provides hash functions for strings. The functions mix the input bits thoroughly but are not suitable for cryptography.") (license license:expat)))) + +(define-public libconfig + (package + (name "libconfig") + (version "1.5") + (source (origin + (method url-fetch) + (uri (string-append + "http://www.hyperrealm.com/libconfig/libconfig-" + version ".tar.gz")) + (sha256 + (base32 + "1xh3hzk63v4y8815lc5209m3s6ms2cpgw4h5hg462i4f1lwsl7g3")))) + (build-system gnu-build-system) + (home-page "http://www.hyperrealm.com/libconfig/") + (synopsis "C/C++ configuration file library") + (description + "Libconfig is a simple library for manipulating structured configuration +files. This file format is more compact and more readable than XML. And +unlike XML, it is type-aware, so it is not necessary to do string parsing in +application code.") + (license license:lgpl2.1+))) -- 2.5.0 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Hello Ricardo, Thank you for your quick response. Ricardo Wurmus writes: > Hi Roel, > >> From a21ebd71a39bf5000e5809514f0e00185311795d Mon Sep 17 00:00:00 2001 >> From: Roel Janssen >> Date: Thu, 10 Dec 2015 14:45:47 +0100 >> Subject: [PATCH] gnu: Add libconfig. > >> * gnu/packages/libconfig.scm: New file. >> * gnu-system.am (GNU_SYSTEM_MODULES): Add it. > > I have an irrational desire to group similar package expressions in > modules rather than to add new modules. In this case we have > “textutils.scm” and “xml.scm” that seem related. > > Someone else should say whether a new module for this is better than > grouping it with one of the above modules. If a new module is indeed > warranted the commit message is perfect. Sorry about creating yet another file. I looked at filenames to find a place to put this in, but I hadn't looked careful enough it seems. I think this fits in 'textutils.scm' indeed. The updated version of the patch should be better. >> +(define-public libconfig >> + (package >> + (name "libconfig") >> + (version "1.5") >> + (source (origin >> + (method url-fetch) >> + (uri (string-append >> + "http://www.hyperrealm.com/libconfig/libconfig-" >> + version ".tar.gz")) >> + (sha256 >> + (base32 >> + "1xh3hzk63v4y8815lc5209m3s6ms2cpgw4h5hg462i4f1lwsl7g3")))) >> + (build-system gnu-build-system) >> + (home-page "http://www.hyperrealm.com/libconfig/") >> + (synopsis "C/C++ configuration file library") >> + (description >> + "Libconfig is a simple library for manipulating structured configuration >> +files. This file format is more compact and more readable than XML. And >> +unlike XML, it is type-aware, so it is not necessary to do string parsing in >> +application code.") >> + (license license:lgpl2.1))) > > The license is actually “lgpl2.1+” because the file headers say this: > > “either version 2.1 of the License, or (at your option) any later > version.” You're right. I updated the patch. Hopefully I haven't screwed up the commit message. :) Thanks, Roel --=-=-=--