[PATCH] Add libconfig.

[PATCH] Add libconfig.

[Roel Janssen]

[-- Attachment #1: 0001-gnu-Add-libconfig.patch --]
[-- Type: text/x-patch, Size: 2914 bytes --]

From a21ebd71a39bf5000e5809514f0e00185311795d Mon Sep 17 00:00:00 2001
From: Roel Janssen <roel@gnu.org>
Date: Thu, 10 Dec 2015 14:45:47 +0100
Subject: [PATCH] gnu: Add libconfig.

* gnu/packages/libconfig.scm: New file.
* gnu-system.am (GNU_SYSTEM_MODULES): Add it.
---
 gnu-system.am              |  1 +
 gnu/packages/libconfig.scm | 45 +++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 46 insertions(+)
 create mode 100644 gnu/packages/libconfig.scm

diff --git a/gnu-system.am b/gnu-system.am
index ec9f63c..7e567c9 100644
--- a/gnu-system.am
+++ b/gnu-system.am
@@ -177,6 +177,7 @@ GNU_SYSTEM_MODULES =				\
   gnu/packages/less.scm				\
   gnu/packages/lesstif.scm			\
   gnu/packages/libcanberra.scm			\
+  gnu/packages/libconfig.scm			\
   gnu/packages/libdaemon.scm			\
   gnu/packages/libedit.scm			\
   gnu/packages/libevent.scm			\
diff --git a/gnu/packages/libconfig.scm b/gnu/packages/libconfig.scm
new file mode 100644
index 0000000..4f59377
--- /dev/null
+++ b/gnu/packages/libconfig.scm
@@ -0,0 +1,45 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2015 Roel Janssen <roel@gnu.org>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages libconfig)
+  #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (guix packages)
+  #:use-module (guix download)
+  #:use-module (guix build-system gnu))
+
+(define-public libconfig
+  (package
+    (name "libconfig")
+    (version "1.5")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "http://www.hyperrealm.com/libconfig/libconfig-"
+                    version ".tar.gz"))
+              (sha256
+               (base32
+                "1xh3hzk63v4y8815lc5209m3s6ms2cpgw4h5hg462i4f1lwsl7g3"))))
+    (build-system gnu-build-system)
+    (home-page "http://www.hyperrealm.com/libconfig/")
+    (synopsis "C/C++ configuration file library")
+    (description
+     "Libconfig is a simple library for manipulating structured configuration
+files.  This file format is more compact and more readable than XML.  And
+unlike XML, it is type-aware, so it is not necessary to do string parsing in
+application code.")
+    (license license:lgpl2.1)))
-- 
2.5.0


[-- Attachment #2: Type: text/plain, Size: 388 bytes --]

Dear list,

This is a patch to add libconfig.  It's a simple library without any
special dependencies.  The reason to add this, is because I'm packaging
other software that depends on libconfig.

I ran guix lint on it, but I still have a problem with TLS, so I'm not
100% confident running guix lint is clean.  Please let me know if
something is wrong with the patch.

Kind regards,
Roel

Re: [PATCH] Add libconfig.

[Ricardo Wurmus]

Hi Roel,

> This is a patch to add libconfig.  It's a simple library without any
> special dependencies.  The reason to add this, is because I'm packaging
> other software that depends on libconfig.
>
> I ran guix lint on it, but I still have a problem with TLS, so I'm not
> 100% confident running guix lint is clean.  Please let me know if
> something is wrong with the patch.

this looks really good.  Thank you.

> From a21ebd71a39bf5000e5809514f0e00185311795d Mon Sep 17 00:00:00 2001
> From: Roel Janssen <roel@gnu.org>
> Date: Thu, 10 Dec 2015 14:45:47 +0100
> Subject: [PATCH] gnu: Add libconfig.

> * gnu/packages/libconfig.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.

I have an irrational desire to group similar package expressions in
modules rather than to add new modules.  In this case we have
“textutils.scm” and “xml.scm” that seem related.

Someone else should say whether a new module for this is better than
grouping it with one of the above modules.  If a new module is indeed
warranted the commit message is perfect.

> +(define-public libconfig
> +  (package
> +    (name "libconfig")
> +    (version "1.5")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "http://www.hyperrealm.com/libconfig/libconfig-"
> +                    version ".tar.gz"))
> +              (sha256
> +               (base32
> +                "1xh3hzk63v4y8815lc5209m3s6ms2cpgw4h5hg462i4f1lwsl7g3"))))
> +    (build-system gnu-build-system)
> +    (home-page "http://www.hyperrealm.com/libconfig/")
> +    (synopsis "C/C++ configuration file library")
> +    (description
> +     "Libconfig is a simple library for manipulating structured configuration
> +files.  This file format is more compact and more readable than XML.  And
> +unlike XML, it is type-aware, so it is not necessary to do string parsing in
> +application code.")
> +    (license license:lgpl2.1)))

The license is actually “lgpl2.1+” because the file headers say this:

    “either version 2.1 of the License, or (at your option) any later
    version.”

Other than that it looks perfect to me.  Thanks again!

~~ Ricardo

Re: [PATCH] Add libconfig.

[Roel Janssen]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: 0001-gnu-Add-libconfig-v2.patch --]
[-- Type: text/x-patch, Size: 1577 bytes --]

From 72e065fc7c8012508ee8ac2963ac25a7c173d33f Mon Sep 17 00:00:00 2001
From: Roel Janssen <roel@gnu.org>
Date: Thu, 10 Dec 2015 16:15:04 +0100
Subject: [PATCH] gnu: Add libconfig.

* gnu/packages/textutils.scm (libconfig): New variable.
---
 gnu/packages/textutils.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/textutils.scm b/gnu/packages/textutils.scm
index e020290..2aa8615 100644
--- a/gnu/packages/textutils.scm
+++ b/gnu/packages/textutils.scm
@@ -179,3 +179,25 @@ the Hannon Lab.")
      "CityHash provides hash functions for strings.  The functions mix the
 input bits thoroughly but are not suitable for cryptography.")
     (license license:expat))))
+
+(define-public libconfig
+  (package
+    (name "libconfig")
+    (version "1.5")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "http://www.hyperrealm.com/libconfig/libconfig-"
+                    version ".tar.gz"))
+              (sha256
+               (base32
+                "1xh3hzk63v4y8815lc5209m3s6ms2cpgw4h5hg462i4f1lwsl7g3"))))
+    (build-system gnu-build-system)
+    (home-page "http://www.hyperrealm.com/libconfig/")
+    (synopsis "C/C++ configuration file library")
+    (description
+     "Libconfig is a simple library for manipulating structured configuration
+files.  This file format is more compact and more readable than XML.  And
+unlike XML, it is type-aware, so it is not necessary to do string parsing in
+application code.")
+    (license license:lgpl2.1+)))
-- 
2.5.0


[-- Attachment #2: Type: text/plain, Size: 2192 bytes --]

Hello Ricardo,

Thank you for your quick response.

Ricardo Wurmus writes:

> Hi Roel,
>
>> From a21ebd71a39bf5000e5809514f0e00185311795d Mon Sep 17 00:00:00 2001
>> From: Roel Janssen <roel@gnu.org>
>> Date: Thu, 10 Dec 2015 14:45:47 +0100
>> Subject: [PATCH] gnu: Add libconfig.
>
>> * gnu/packages/libconfig.scm: New file.
>> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.
>
> I have an irrational desire to group similar package expressions in
> modules rather than to add new modules.  In this case we have
> “textutils.scm” and “xml.scm” that seem related.
>
> Someone else should say whether a new module for this is better than
> grouping it with one of the above modules.  If a new module is indeed
> warranted the commit message is perfect.

Sorry about creating yet another file.  I looked at filenames to find a
place to put this in, but I hadn't looked careful enough it seems.  I
think this fits in 'textutils.scm' indeed.  The updated version of the
patch should be better.

>> +(define-public libconfig
>> +  (package
>> +    (name "libconfig")
>> +    (version "1.5")
>> +    (source (origin
>> +              (method url-fetch)
>> +              (uri (string-append
>> +                    "http://www.hyperrealm.com/libconfig/libconfig-"
>> +                    version ".tar.gz"))
>> +              (sha256
>> +               (base32
>> +                "1xh3hzk63v4y8815lc5209m3s6ms2cpgw4h5hg462i4f1lwsl7g3"))))
>> +    (build-system gnu-build-system)
>> +    (home-page "http://www.hyperrealm.com/libconfig/")
>> +    (synopsis "C/C++ configuration file library")
>> +    (description
>> +     "Libconfig is a simple library for manipulating structured configuration
>> +files.  This file format is more compact and more readable than XML.  And
>> +unlike XML, it is type-aware, so it is not necessary to do string parsing in
>> +application code.")
>> +    (license license:lgpl2.1)))
>
> The license is actually “lgpl2.1+” because the file headers say this:
>
>     “either version 2.1 of the License, or (at your option) any later
>     version.”

You're right. I updated the patch.

Hopefully I haven't screwed up the commit message. :)

Thanks,
Roel

Re: [PATCH] Add libconfig.

[Ricardo Wurmus]

Roel Janssen <roel@gnu.org> writes:

> Sorry about creating yet another file.  I looked at filenames to find a
> place to put this in, but I hadn't looked careful enough it seems.  I
> think this fits in 'textutils.scm' indeed.  The updated version of the
> patch should be better.

Nice!

I amended your commit to add your copyright line to the top of the file
and slightly changed the formatting of the URL line, and then pushed to
master.  I hope that’s okay.

Thanks again!

~~ Ricardo

Re: [PATCH] Add libconfig.

[Roel Janssen]

Ricardo Wurmus writes:

> Roel Janssen <roel@gnu.org> writes:
>
>> Sorry about creating yet another file.  I looked at filenames to find a
>> place to put this in, but I hadn't looked careful enough it seems.  I
>> think this fits in 'textutils.scm' indeed.  The updated version of the
>> patch should be better.
>
> Nice!
>
> I amended your commit to add your copyright line to the top of the file
> and slightly changed the formatting of the URL line, and then pushed to
> master.  I hope that’s okay.

Yes, that's okay.

Thanks,
Roel

Re: [PATCH] Add libconfig.

[Ludovic Courtès]

Roel Janssen <roel@gnu.org> skribis:

> I ran guix lint on it, but I still have a problem with TLS, so I'm not
> 100% confident running guix lint is clean.

What problem exactly?  For some of its checkers, ‘guix lint’ wants
(gnutls), the Guile bindings to GnuTLS.  If you get an error along the
lines of:

  No code for module (gnutls)

then I’d recommend running ‘guix package -i gnutls’.

HTH!

Ludo’.

Re: [PATCH] Add libconfig.

[Roel Janssen]

Ludovic Courtès writes:

> Roel Janssen <roel@gnu.org> skribis:
>
>> I ran guix lint on it, but I still have a problem with TLS, so I'm not
>> 100% confident running guix lint is clean.
>
> What problem exactly?  For some of its checkers, ‘guix lint’ wants
> (gnutls), the Guile bindings to GnuTLS.  If you get an error along the
> lines of:
>
>   No code for module (gnutls)
>
> then I’d recommend running ‘guix package -i gnutls’.

Thank you for your help!  I was missing gnutls-guile.  It's actually in
the manual but I hadn't read it yet at that point.  (I'm still reading
and processing the information from the manual.).  So future patches
will be properly checked with 'guix lint'.