From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: Re: wip-refactor-emacs-ui and Hydra interface Date: Fri, 18 Dec 2015 21:53:12 +0300 Message-ID: <8760zv4mhz.fsf@gmail.com> References: <87vb85gqes.fsf@gmail.com> <8760zwhfyi.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:41950) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aA09Y-0003Ac-AX for guix-devel@gnu.org; Fri, 18 Dec 2015 13:53:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aA09U-0006OS-Ae for guix-devel@gnu.org; Fri, 18 Dec 2015 13:53:20 -0500 List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org Ludovic Court=C3=A8s (2015-12-18 01:23 +0300) wrote: > Hi Alex! > > Sorry for the late reply. I wanted to take the time to sit back, relax, > and enjoy the new stuff=E2=80=A6 and I haven=E2=80=99t been disappointed= ! :-) Great, thanks for giving your time to this! > This is awesome. Some queries seem to take longer on Hydra than others > (for instance, getting the list of builds of a given jobset is slow, > whereas getting the list of latest builds, queued builds, etc. is pretty > fast.) Yes, I also noticed that processing complex queries takes longer time. Perhaps SQL queries that stand behind this Hydra API are not efficient, dunno :-) > Perhaps one small improvement would be to add links from Package Info > buffers to the corresponding Guix Hydra Build Info? Do you mean a button that will do the same as "B" key in "Package List"? Anyway, I think eventually I'll add more various buttons to "Package Info" buffers (like "Hydra Builds", "Build Log", "Size", "Graph"), and more keys to "Package List" buffers for the same things. > I haven=E2=80=99t looked at the code yet, but it=E2=80=99s your area of e= xpertise and > I=E2=80=99m confident. :-) I skim over it when you think it=E2=80=99s r= eady; are there > parts you=E2=80=99d like to be reviewed more carefully? Well, I always feel uncomfortable with commit messages. But I think the main part that should be reviewed is documentation (in commit 731f5e4). As for the changes in code, they are huge (and I would say "unskimmable"), and I think no one will want to look at them :-) > Anyway, let me know what you think and how you=E2=80=99d like to proceed. OK, I have done some final changes and rebased the branch on master, so (from my point of view) it is ready for merging. Should I spam the list with these (37) patches? --=20 Alex