From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] Gemspecs / Add ruby-ruby-engine. Date: Tue, 05 Jan 2016 17:53:08 +0100 Message-ID: <8760z83r4b.fsf@gnu.org> References: <5683842C.3090706@uq.edu.au> <568BB25E.3040805@uq.edu.au> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:36220) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aGUrC-00028v-R0 for guix-devel@gnu.org; Tue, 05 Jan 2016 11:53:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aGUr9-0007pp-KS for guix-devel@gnu.org; Tue, 05 Jan 2016 11:53:14 -0500 In-Reply-To: (Ricardo Wurmus's message of "Tue, 5 Jan 2016 15:47:28 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ricardo Wurmus Cc: "guix-devel@gnu.org" Ricardo Wurmus skribis: > But how does this relate to snippets? In other build systems snippets > cause the source archive to be unpacked, modified, and then repacked. > If we split unpacking and gemspec extraction we=E2=80=99d have to make su= re that > this also works when snippets are involved, i.e. snippets should see the > extracted gemspec (as the original one is discarded by the build system > anyway). The implementation of snippets is in =E2=80=98patch-and-repack=E2=80=99 pro= cedure; it is completely independent of build systems and their phases. > Agreed. I=E2=80=99d be happy if someone else could chime in to give an o= pinion > on whether to add a new phase or merge gemspec extraction with =E2=80=9Cu= npack=E2=80=9D. I think I don=E2=80=99t understand the issue at hand sufficiently well. Two things come to mind: =E2=80=9Cextract=E2=80=9D and =E2=80=9Cunpack=E2=80=9D= sound synonymous; OTOH, having a separate phase provides more flexibility, since one can remove it, replace it, etc. Ludo=E2=80=99.