From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alex Kost <alezost@gmail.com>
Subject: Re: [PATCH 3/4] gnu: emacs: Find packages in "~/.guix-profile".
Date: Tue, 12 Jan 2016 12:18:11 +0300
Message-ID: <8760yzma0c.fsf@gmail.com>
References: <1452099305-746-1-git-send-email-alezost@gmail.com>
	<1452099305-746-4-git-send-email-alezost@gmail.com>
	<87mvsd41t6.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55275)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1aIv5l-00010P-Hk
	for guix-devel@gnu.org; Tue, 12 Jan 2016 04:18:18 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1aIv5h-0001mj-AO
	for guix-devel@gnu.org; Tue, 12 Jan 2016 04:18:17 -0500
In-Reply-To: <87mvsd41t6.fsf@gnu.org> ("Ludovic
	\=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\=
	\=\?utf-8\?Q\?s\?\= message of "Sun, 10 Jan 2016 21:28:05 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: guix-devel@gnu.org, Federico Beffa <beffa@fbengineering.ch>

Ludovic Court=C3=A8s (2016-01-10 23:28 +0300) wrote:

> Alex Kost <alezost@gmail.com> skribis:
>
>> From: Federico Beffa <beffa@fbengineering.ch>
>>
>> * gnu/packages/emacs.scm (emacs)[inputs]: Add 'guix-src' input.
>>   [arguments]: Add 'install-site-start' phase.
>
> [...]
>
>> +         (add-after 'install 'install-site-start
>
> Could you add a comment like:
>
>   ;; Copy guix-emacs.el from Guix and add it to site-start.el.  This
>   ;; way, Emacs packages provided by Guix and installed in
>   ;; ~/.guix-profile/share/emacs/site-lisp/guix.d/PACKAGE-VERSION are
>   ;; automatically found.
>
> Otherwise LGTM.

Done for this and for your notes on other patches, thanks!

> Also, on GuixSD, should we remove the default EMACSLOADPATH as well as
> /etc/emacs/site-start.el?

If the goal for GuixSD is just to make Emacs packages work, then yes;
but if the intention is also to make "M-x guix-..." commands work
out-of-the-box, then we should leave it as it is now.

--=20
Alex