From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH 0/1] Add transmission-remote-cli Date: Wed, 20 Jan 2016 23:42:08 +0100 Message-ID: <8760ynvpof.fsf@gnu.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:41539) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aM1SB-0005MK-IL for guix-devel@gnu.org; Wed, 20 Jan 2016 17:42:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aM1S7-000880-DJ for guix-devel@gnu.org; Wed, 20 Jan 2016 17:42:15 -0500 In-Reply-To: (Leo Famulari's message of "Mon, 18 Jan 2016 01:53:35 -0500") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Leo Famulari Cc: guix-devel@gnu.org Leo Famulari skribis: > Transmission-remote-cli is a curses-interface client for the > Transmission bittorrent daemon. > > The package is one python script, a man page, and a Bash shell > completion script. So, I deleted the build phase and replaced the > install phase. Is that okay? Sure. In some cases, it=E2=80=99s also possible to use the dumb =E2=80=98trivial-build-system=E2=80=99, but sometimes its dumbness makes it inconvenient. > Also, do we have a standard way to install Zsh shell completions? This > software provides them, but this package does not. I don=E2=80=99t know, we should install them wherever Zsh will look for the= m. For Bash, we have bash-completion-directories.patch. > * gnu/packages/bittorrent.scm (transmission-remote-cli): New variable. Please add a copyright line for yourself. Otherwise LGTM. Thanks! Ludo=E2=80=99.