From mboxrd@z Thu Jan  1 00:00:00 1970
From: iyzsong@member.fsf.org (=?utf-8?B?5a6L5paH5q2m?=)
Subject: Re: [PATCH] gnu: xfce: =?utf-8?Q?Don=E2=80=99t?= wrap startxfce4.
Date: Wed, 02 Mar 2016 08:33:17 +0800
Message-ID: <8760x590s2.fsf_-_@member.fsf.org>
References: <20160225203658.GA24846@solar> <87ziujj43y.fsf@member.fsf.org>
	<87lh61nb3e.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34775)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <iyzsong@openmailbox.org>) id 1aaujZ-0003CA-4F
	for guix-devel@gnu.org; Tue, 01 Mar 2016 19:33:45 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <iyzsong@openmailbox.org>) id 1aaujU-0003Rf-IM
	for guix-devel@gnu.org; Tue, 01 Mar 2016 19:33:45 -0500
Received: from smtp10.openmailbox.org ([62.4.1.44]:42853)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <iyzsong@openmailbox.org>) id 1aaujU-0003Nr-D2
	for guix-devel@gnu.org; Tue, 01 Mar 2016 19:33:40 -0500
In-Reply-To: <87lh61nb3e.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?=
	=?utf-8?Q?s?= message of "Tue, 01 Mar 2016 22:26:45 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: guix-devel@gnu.org

ludo@gnu.org (Ludovic Court=C3=A8s) writes:

> iyzsong@member.fsf.org (=E5=AE=8B=E6=96=87=E6=AD=A6) skribis:
>
> [...]
>>
>> This package was introduced before the =E2=80=98etc/profile=E2=80=99 whe=
re enviroment
>> variables from search-paths are set.  So, the wrapper is redundant now.
>
> The wrapper would still be useful when it=E2=80=99s not installed in a pr=
ofile
> (for instance, when running $(guix build xfce4)/bin/startxfce4), but
> that=E2=80=99s probably not a use case worth supporting in this case.
> Thoughts?
I guess so, in that way other packages aren't in PATH.
>
>> From 6f6ba4e8c347770b279e9344ba49bf305cd41da8 Mon Sep 17 00:00:00 2001
>> From: =3D?UTF-8?q?=3DE5=3DAE=3D8B=3DE6=3D96=3D87=3DE6=3DAD=3DA6?=3D <iyz=
song@gmail.com>
>> Date: Mon, 29 Feb 2016 14:57:56 +0800
>> Subject: [PATCH] gnu: xfce: Don't wrap 'startxfce4'.
>>
>> The necessary environment variables are set by 'etc/profile' now.
>>
>> * gnu/packages/xfce.scm (xfce)[build-system]: Use 'trivial-build-system'.
>> [arguments]: Simplify.
>
> Otherwise the patch LGTM.
Pushed, thanks!