From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alex Kost <alezost@gmail.com>
Subject: Re: [v2 2/2] gnu: Add signify.
Date: Sat, 02 Apr 2016 10:47:21 +0300
Message-ID: <8760w0a1va.fsf@gmail.com>
References: <cover.1459560195.git.leo@famulari.name>
	<521584dad223b3cb86c5a11ec2107a8eddf6474b.1459560195.git.leo@famulari.name>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55078)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1amGHC-0000XB-U5
	for guix-devel@gnu.org; Sat, 02 Apr 2016 03:47:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1amGHB-0006pw-Vj
	for guix-devel@gnu.org; Sat, 02 Apr 2016 03:47:22 -0400
Received: from mail-lb0-x231.google.com ([2a00:1450:4010:c04::231]:34561)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1amGHB-0006pd-NY
	for guix-devel@gnu.org; Sat, 02 Apr 2016 03:47:21 -0400
Received: by mail-lb0-x231.google.com with SMTP id vo2so90824173lbb.1
	for <guix-devel@gnu.org>; Sat, 02 Apr 2016 00:47:21 -0700 (PDT)
In-Reply-To: <521584dad223b3cb86c5a11ec2107a8eddf6474b.1459560195.git.leo@famulari.name>
	(Leo Famulari's message of "Fri, 1 Apr 2016 21:24:34 -0400")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org

Leo Famulari (2016-04-02 04:24 +0300) wrote:

> * gnu/packages/crypto.scm (signify): New variable.
> ---
>  gnu/packages/crypto.scm | 35 +++++++++++++++++++++++++++++++++++
>  1 file changed, 35 insertions(+)
[...]
> +(define-public signify
> +  (package
> +    (name "signify")
> +    (version "17")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "https://github.com/aperezdc/signify/"
> +                                  "archive/v" version ".tar.gz"))

Don't forget about "guix lint": you are missing (file-name ...) field here.

> +              (sha256
> +               (base32
> +                "0kfv2k1fqck31vwlnicavb0h541ilad9zd7j8zz8x2kx36wwqpr7"))=
))
> +    (build-system gnu-build-system)
> +    ;; TODO Build with libwaive (described in README.md), to implement s=
omething
> +    ;; like OpenBSD's pledge().
> +    (arguments
> +     `(#:make-flags
> +       (list "CC=3Dgcc"
> +             (string-append "PREFIX=3D" (assoc-ref %outputs "out")))
> +       #:phases
> +       (modify-phases %standard-phases
> +         (delete 'configure)
> +         (delete 'check)))) ; no test suite

I think it's better to add =E2=80=9C#:tests? #f=E2=80=9D to arguments inste=
ad, as we do
for other packages.

> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)))
> +    (inputs
> +     `(("libbsd" ,libbsd)))
> +    (synopsis "Create and verify cryptographic signatures")
> +    (description "The signify utility creates and verifies cryptographic
> +signatures using the elliptic curve Ed25519.")
> +    (home-page "https://github.com/aperezdc/signify")
> +    (license (list bsd-3 bsd-4 isc public-domain non-copyleft))))

The same note as for 'libbsd': non-copyleft is a procedure.

--=20
Alex