From: Alex Kost <alezost@gmail.com>
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org
Subject: Re: [v2 2/2] gnu: Add signify.
Date: Sat, 02 Apr 2016 10:47:21 +0300 [thread overview]
Message-ID: <8760w0a1va.fsf@gmail.com> (raw)
In-Reply-To: <521584dad223b3cb86c5a11ec2107a8eddf6474b.1459560195.git.leo@famulari.name> (Leo Famulari's message of "Fri, 1 Apr 2016 21:24:34 -0400")
Leo Famulari (2016-04-02 04:24 +0300) wrote:
> * gnu/packages/crypto.scm (signify): New variable.
> ---
> gnu/packages/crypto.scm | 35 +++++++++++++++++++++++++++++++++++
> 1 file changed, 35 insertions(+)
[...]
> +(define-public signify
> + (package
> + (name "signify")
> + (version "17")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append "https://github.com/aperezdc/signify/"
> + "archive/v" version ".tar.gz"))
Don't forget about "guix lint": you are missing (file-name ...) field here.
> + (sha256
> + (base32
> + "0kfv2k1fqck31vwlnicavb0h541ilad9zd7j8zz8x2kx36wwqpr7"))))
> + (build-system gnu-build-system)
> + ;; TODO Build with libwaive (described in README.md), to implement something
> + ;; like OpenBSD's pledge().
> + (arguments
> + `(#:make-flags
> + (list "CC=gcc"
> + (string-append "PREFIX=" (assoc-ref %outputs "out")))
> + #:phases
> + (modify-phases %standard-phases
> + (delete 'configure)
> + (delete 'check)))) ; no test suite
I think it's better to add “#:tests? #f” to arguments instead, as we do
for other packages.
> + (native-inputs
> + `(("pkg-config" ,pkg-config)))
> + (inputs
> + `(("libbsd" ,libbsd)))
> + (synopsis "Create and verify cryptographic signatures")
> + (description "The signify utility creates and verifies cryptographic
> +signatures using the elliptic curve Ed25519.")
> + (home-page "https://github.com/aperezdc/signify")
> + (license (list bsd-3 bsd-4 isc public-domain non-copyleft))))
The same note as for 'libbsd': non-copyleft is a procedure.
--
Alex
next prev parent reply other threads:[~2016-04-02 7:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-02 1:24 [v2 0/2] Signify Leo Famulari
2016-04-02 1:24 ` [v2 1/2] gnu: Add libbsd Leo Famulari
2016-04-02 7:47 ` Alex Kost
2016-04-02 17:21 ` Leo Famulari
2016-04-02 1:24 ` [v2 2/2] gnu: Add signify Leo Famulari
2016-04-02 7:47 ` Alex Kost [this message]
2016-04-02 17:22 ` Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760w0a1va.fsf@gmail.com \
--to=alezost@gmail.com \
--cc=guix-devel@gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.