From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: hurd: Remove inputs no longer needed and move
	configure flags.
Date: Tue, 07 Jun 2016 15:43:11 +0200
Message-ID: <8760tl9ksw.fsf@gnu.org>
References: <e33375f5-0440-19c5-c4cd-da401e4c94b3@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37996)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bAHHs-00060e-Ks
	for guix-devel@gnu.org; Tue, 07 Jun 2016 09:43:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bAHHn-00057G-IE
	for guix-devel@gnu.org; Tue, 07 Jun 2016 09:43:19 -0400
In-Reply-To: <e33375f5-0440-19c5-c4cd-da401e4c94b3@gmail.com> (Manolis
	Ragkousis's message of "Tue, 7 Jun 2016 15:00:44 +0300")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Manolis Ragkousis <manolis837@gmail.com>
Cc: guix-devel@gnu.org

Manolis Ragkousis <manolis837@gmail.com> skribis:

> From 984de2d0e26b1ddd860d0468453ee8679ced756d Mon Sep 17 00:00:00 2001
> From: Manolis Ragkousis <manolis837@gmail.com>
> Date: Tue, 7 Jun 2016 14:45:55 +0300
> Subject: [PATCH] gnu: hurd: Remove inputs no longer needed and move confi=
gure
>  flags.
>
> * gnu/packages/hurd.scm (hurd-minimal)[arguments]: Move configure-flags f=
rom here..
>   (hurd-headers)[arguments]: ..to here.

They are not just moved, there=E2=80=99s also the change for --host.  It wo=
uld
be great if, for clarity, you made one patch for the --host change (like
you did before), one for the actual move, and=E2=80=A6

>   (hurd-headers, hurd-minimal)[native-inputs]: Remove "autoconf".

=E2=80=A6 another one for this.

Does that sound reasonable?

Apart from this nitpicking, it looks good to me, thanks!

Ludo=E2=80=99.