From: ludo@gnu.org (Ludovic Courtès)
To: Eric Bavier <ericbavier@openmailbox.org>
Cc: guix-devel@gnu.org, David Craven <david@craven.ch>
Subject: Re: [PATCH 3/4] lint: Add 'inputs-should-be-sorted' check.
Date: Thu, 21 Jul 2016 18:00:24 +0200 [thread overview]
Message-ID: <8760rzm15z.fsf@gnu.org> (raw)
In-Reply-To: <20160721081710.41c69c50@openmailbox.org> (Eric Bavier's message of "Thu, 21 Jul 2016 08:17:10 -0500")
Eric Bavier <ericbavier@openmailbox.org> skribis:
> On Tue, 19 Jul 2016 18:49:15 +0200
> David Craven <david@craven.ch> wrote:
>
>> * guix/scripts/lint.scm (check-inputs-should-be-sorted): Add it.
>> (lint-checker): Add it.
>> ---
>> guix/scripts/lint.scm | 19 +++++++++++++++++++
>> 1 file changed, 19 insertions(+)
>>
>> diff --git a/guix/scripts/lint.scm b/guix/scripts/lint.scm
>> index d64a066..d3a82c9 100644
>> --- a/guix/scripts/lint.scm
>> +++ b/guix/scripts/lint.scm
>> @@ -220,6 +220,21 @@ by two spaces; possible infraction~p at ~{~a~^, ~}")
>> (when (string-suffix? ":bin" package-name) (warn package-name)))
>> labels)))))))
>>
>> +(define (check-inputs-should-be-sorted package)
>> + ;; Emit a warning if inputs, native-inputs or propagated-inputs are not sorted.
>
> I don't think this needs to be a thing. While I personally added the
> code in the cpan importer to sort inputs by name, I recognize that
> there are also valid reasons to not do that in some packages. E.g.
> grouping a set of inputs that are all related to or required for some
> aspect of a package's functionality, etc.
Yeah, I agree.
Ludo’.
next prev parent reply other threads:[~2016-07-21 16:00 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-19 16:49 [PATCH 0/4] Dipping my toes into guix source David Craven
2016-07-19 16:49 ` [PATCH 1/4] lint: Add packages with suffix ':bin' to 'inputs-should-be-native' David Craven
2016-07-20 10:37 ` Ludovic Courtès
2016-07-20 10:50 ` David Craven
2016-07-20 11:19 ` Efraim Flashner
2016-07-21 12:24 ` Ludovic Courtès
2016-07-21 13:22 ` Vincent Legoll
2016-07-21 16:06 ` Ludovic Courtès
2016-07-21 19:27 ` Tobias Geerinckx-Rice
2016-07-22 13:32 ` Ludovic Courtès
2016-07-22 14:07 ` Vincent Legoll
2016-07-19 16:49 ` [PATCH 2/4] gnu: Rename 'glib' label to 'glib:bin' where appropriate David Craven
2016-07-22 12:57 ` Ludovic Courtès
2016-07-22 13:03 ` David Craven
2016-07-22 17:55 ` David Craven
2016-07-19 16:49 ` [PATCH 3/4] lint: Add 'inputs-should-be-sorted' check David Craven
2016-07-21 13:17 ` Eric Bavier
2016-07-21 16:00 ` Ludovic Courtès [this message]
2016-07-19 16:49 ` [PATCH 4/4] environment: Add '--debug' flag David Craven
2016-07-19 17:14 ` Thompson, David
2016-07-19 18:00 ` Tobias Geerinckx-Rice
2016-07-19 18:10 ` David Craven
2016-07-19 19:02 ` David Craven
2016-07-19 19:06 ` Thompson, David
2016-07-19 19:15 ` David Craven
2016-07-20 4:17 ` Leo Famulari
2016-07-20 10:35 ` Ludovic Courtès
2016-07-20 10:56 ` David Craven
2016-07-19 20:11 ` Danny Milosavljevic
2016-07-20 7:18 ` Alex Kost
2016-07-20 7:35 ` Vincent Legoll
2016-07-20 9:15 ` Pjotr Prins
2016-07-22 19:54 ` Customising linux-libre (was: [PATCH 4/4] environment: Add '--debug' flag.) Tobias Geerinckx-Rice
2016-07-22 19:58 ` Vincent Legoll
2016-07-22 20:00 ` David Craven
2016-07-22 20:03 ` Vincent Legoll
2016-07-22 20:15 ` Customising linux-libre Tobias Geerinckx-Rice
2016-07-22 20:50 ` David Craven
2016-07-22 20:11 ` Tobias Geerinckx-Rice
2016-07-23 10:38 ` Ludovic Courtès
2016-07-21 12:22 ` [PATCH 4/4] environment: Add '--debug' flag Ludovic Courtès
2016-07-21 12:30 ` David Craven
2016-07-21 16:03 ` Ludovic Courtès
2016-07-21 16:12 ` David Craven
2016-07-21 16:38 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760rzm15z.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=david@craven.ch \
--cc=ericbavier@openmailbox.org \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.