From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: Re: [PATCH] gnu: Add emacs-flx. Date: Mon, 29 Aug 2016 12:09:37 +0300 Message-ID: <8760qk2b72.fsf@gmail.com> References: <87lgzgju24.fsf@we.make.ritual.n0.is> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:47358) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1beIZc-0002kx-VT for guix-devel@gnu.org; Mon, 29 Aug 2016 05:09:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1beIZX-0003QI-Pd for guix-devel@gnu.org; Mon, 29 Aug 2016 05:09:43 -0400 Received: from mail-lf0-x242.google.com ([2a00:1450:4010:c07::242]:36325) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1beIZX-0003QC-I3 for guix-devel@gnu.org; Mon, 29 Aug 2016 05:09:39 -0400 Received: by mail-lf0-x242.google.com with SMTP id 33so6613197lfw.3 for ; Mon, 29 Aug 2016 02:09:39 -0700 (PDT) In-Reply-To: <87lgzgju24.fsf@we.make.ritual.n0.is> (ng0@we.make.ritual.n0.is's message of "Mon, 29 Aug 2016 00:30:11 +0000") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: ng0 Cc: guix-devel@gnu.org ng0 (2016-08-29 03:30 +0300) wrote: > From c16f7200c00a5203614d6aa6c8b4ddec76545b93 Mon Sep 17 00:00:00 2001 > From: ng0 > Date: Sun, 28 Aug 2016 23:25:53 +0000 > Subject: [PATCH 1/4] gnu: Add emacs-flx. > > * gnu/packages/emacs.scm (emacs-flx): New variable. > --- > gnu/packages/emacs.scm | 27 +++++++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > > > diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm > index 4fe9a8a..e7989a0 100644 > --- a/gnu/packages/emacs.scm > +++ b/gnu/packages/emacs.scm > @@ -3002,3 +3002,30 @@ lists, and project planning with a fast and effective plain-text system. It > also is an authoring system with unique support for literate programming and > reproducible research.") > (license license:gpl3+))) > + > +(define-public emacs-flx > + (let ((upstream-name "flx")) This is not done for the other packages (except commit 5698b8b82ce which is very unusual by itself), and I don't think it is needed. If you insist, it's probably better to move this 'let' inside origin uri, but I would just remove it, and write the name inside uri in a usual manner. > + (package > + (name "emacs-flx") > + (version "0.6.1") > + (source > + (origin > + (method url-fetch) > + (uri (string-append "https://github.com/lewang/" > + upstream-name "/archive/v" version ".tar.gz")) > + (sha256 > + (base32 > + "0bkcpnf1j4i2fcc2rllwbz62l00sw2mcia6rm5amgwvlkqavmkv6")) > + (file-name (string-append name "-" version ".tar.gz")))) > + (build-system emacs-build-system) > + (native-inputs > + `(("emacs-async" ,emacs-async))) This library is not needed. You probably added it to make "tests/flx-test.el" compiled, but don't bother about it. This tests dir is not a part of this emacs package. Ideally such files should be removed by emacs-build-system, but currently it just leaves everything from the original source (including .gitignore, .travis.yml, etc.). > + (home-page "https://github.com/lewang/flx") > + (synopsis "Fuzzy matching for Emacs") > + (description > + "Flx provides fuzzy matching for emacs a la sublime text. > +The sorting algorithm is a balance between word beginnings (abbreviation) > +and contiguous matches (substring). The longer the substring match, > +the higher it scores. This maps well to how we think about matching. > +Flx has support for ido (interactively do things) through flx-ido.") > + (license license:gpl3+)))) > -- > > 2.9.3 -- Alex