Re: [PATCH] small patchseries to add the irc bot limnoria.

[ng0 <ng0@we.make.ritual.n0.is>]

Leo Famulari <leo@famulari.name> writes:

> [ Unknown signature status ]
> On Sun, Sep 18, 2016 at 02:14:32PM +0000, ng0 wrote:
>> This is a small patchseries to add the bot limnoria, based on supybot.
>
> Thanks!
>
>> * gnu/packages/python.scm (python-socksipy-branch): New variable.
>
>> +    (home-page "http://code.google.com/p/socksipy-branch/")

Right, it is now https://code.google.com/archive/p/socksipy-branch/
until Google will finally to decide to shut down yet another product
people relied on.

>
> Error 404.
>
>> +(define-public python2-socksipy-branch
>> +  (package-with-python2
>> +   (strip-python2-variant python-socksipy-branch)))
>
> I don't think this needs strip-python2-variant. It should be enough to
> use package-with-python2.

I found this failed very often for me. I can try it again.

>> Subject: [PATCH 2/4] license: Add freebsd-doc.
>> 
>> * guix/licenses.scm (freebsd-doc): New variable.
>
> LGTM
>
>> Subject: [PATCH 3/4] gnu: Add python-feedparser.
>> 
>> * gnu/packages/python.scm (python-feedparser): New variable.
>
> LGTM
>
>> Subject: [PATCH 4/4] gnu: Add limnoria.
>> 
>> * gnu/packages/irc.scm (limnoria): New variable.
>
> LGTM. It would be nice to figure out how to run the tests, if they are
> meant to be run by distributions..
-- 
              ng0