From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Build and install xonsh docs.
Date: Sun, 09 Oct 2016 23:59:15 +0200
Message-ID: <8760p1faks.fsf@gnu.org>
References: <20161007103821.25844-1-dannym@scratchpost.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57590)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1btM7v-0004Nj-IU
	for guix-devel@gnu.org; Sun, 09 Oct 2016 17:59:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1btM7r-00033I-BX
	for guix-devel@gnu.org; Sun, 09 Oct 2016 17:59:22 -0400
In-Reply-To: <20161007103821.25844-1-dannym@scratchpost.org> (Danny
	Milosavljevic's message of "Fri, 7 Oct 2016 12:38:21 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: guix-devel@gnu.org

Hi!

Danny Milosavljevic <dannym@scratchpost.org> skribis:

> * gnu/packages/shells.scm (xonsh): Changed.
> ---
>  gnu/packages/shells.scm | 29 ++++++++++++++++++++++++++---
>  1 file changed, 26 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/packages/shells.scm b/gnu/packages/shells.scm
> index 6d510c2..99d1f3e 100644
> --- a/gnu/packages/shells.scm
> +++ b/gnu/packages/shells.scm
> @@ -291,10 +291,11 @@ ksh, and tcsh.")
>      (source
>        (origin
>          (method url-fetch)
> -        (uri (pypi-uri "xonsh" version))
> +        (uri (string-append "https://github.com/xonsh/xonsh/archive/"
> +                            version ".tar.gz"))
>          (sha256
>            (base32
> -            "0byxd9kjl99q2pyvjh9jy18l0di1i35wr0qqgnw4i6jh6ig3zcki"))
> +            "0v0l3bpyxh2fyhybycjr22sh9v0ggswgmbm9gsyf7yvkrcr5fqzr"))

Is the URL change intended?  Is it needed?  If so, please add a comment
above as to why the github.com tarball is preferred.

> +    (native-inputs
> +     `(("python-numpydoc" ,python-numpydoc)
> +       ("python-sphinx" ,python-sphinx)
> +       ("python-sphinx-cloud-sptheme"
> +        ,python-sphinx-cloud-sptheme)))

I got:

  gnu/packages/shells.scm:323:5: In procedure module-lookup: Unbound variab=
le: python-sphinx-cloud-sptheme

Am I missing another patch that adds this package?

> +      ;; TODO jupyter distro
> +     `(("python-ply" ,python-ply)
> +       ("python-prompt-toolkit" ,python-prompt-toolkit)))

I=E2=80=99m not sure what the comment means.  Maybe remove it?

Thanks!

Ludo=E2=80=99.