Re: [PATCH] gnu: Build and install xonsh docs.

[ludo@gnu.org (Ludovic Courtès)]

Hi!

Danny Milosavljevic <dannym@scratchpost.org> skribis:

> * gnu/packages/shells.scm (xonsh): Changed.
> ---
>  gnu/packages/shells.scm | 29 ++++++++++++++++++++++++++---
>  1 file changed, 26 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/packages/shells.scm b/gnu/packages/shells.scm
> index 6d510c2..99d1f3e 100644
> --- a/gnu/packages/shells.scm
> +++ b/gnu/packages/shells.scm
> @@ -291,10 +291,11 @@ ksh, and tcsh.")
>      (source
>        (origin
>          (method url-fetch)
> -        (uri (pypi-uri "xonsh" version))
> +        (uri (string-append "https://github.com/xonsh/xonsh/archive/"
> +                            version ".tar.gz"))
>          (sha256
>            (base32
> -            "0byxd9kjl99q2pyvjh9jy18l0di1i35wr0qqgnw4i6jh6ig3zcki"))
> +            "0v0l3bpyxh2fyhybycjr22sh9v0ggswgmbm9gsyf7yvkrcr5fqzr"))

Is the URL change intended?  Is it needed?  If so, please add a comment
above as to why the github.com tarball is preferred.

> +    (native-inputs
> +     `(("python-numpydoc" ,python-numpydoc)
> +       ("python-sphinx" ,python-sphinx)
> +       ("python-sphinx-cloud-sptheme"
> +        ,python-sphinx-cloud-sptheme)))

I got:

  gnu/packages/shells.scm:323:5: In procedure module-lookup: Unbound variable: python-sphinx-cloud-sptheme

Am I missing another patch that adds this package?

> +      ;; TODO jupyter distro
> +     `(("python-ply" ,python-ply)
> +       ("python-prompt-toolkit" ,python-prompt-toolkit)))

I’m not sure what the comment means.  Maybe remove it?

Thanks!

Ludo’.