From: ng0 <ng0@we.make.ritual.n0.is>
To: Marius Bakke <mbakke@fastmail.com>, guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add whois.
Date: Sat, 22 Oct 2016 11:04:37 +0000 [thread overview]
Message-ID: <8760okve4a.fsf@we.make.ritual.n0.is> (raw)
In-Reply-To: <87lgxl7kww.fsf@duckhunt.i-did-not-set--mail-host-address--so-tickle-me>
Marius Bakke <mbakke@fastmail.com> writes:
> ng0 <ng0@we.make.ritual.n0.is> writes:
>
>>> * The Debian package is built with HAVE_ICONV=1, should we set that too?
>>
>> I can send an updated patch with libiconv in the inputs. This is when
>> you use a libc which does not provide a (usable) iconv, which is why
>> Gentoo provides the option to build it with this too. As we are
>> _currently_ only providing options to do one libc globally this is not
>> so inmportant. I will even build uclibc-ng (I am working on that) with
>> an outside iconv because reportedly their iconv is in bad shape.
>>
>> So with this information, should I send a new patch which adds libiconv
>> and the build option?
>
> Since we only support glibc at the moment, I don't think adding a
> package for libiconv first is necessary. On the other hand, if it can
> cause problems on other libc's, it's nice to use an external one.
>
> IMO adding libiconv as input is something that can be done later, when
> there is an actual need for it. I guess there are more packages that
> will require it. But I don't really mind either way :)
>
>>> Additionally it installs locales, but looks for /usr/share/locale at
>>> runtime. Fixing this would probably require upstream help, I don't want
>>> to hardcode either "/run/current-system/locale" or ~/.guix-profile. The
>>> current version probably works on foreign distros, if nothing else.
>>
>> If you know how to fix it, try to bring it to upstream or include a
>> patch / substitute phase at our end?
>
> I tried patching whois.c to use the glibc default in the call to
> bindtextdomain(3), instead of the LOCALEDIR build option. That almost
> worked: it searches the system locales, but also expect to find the
> translation files there. I'll see if I can cook up a fix for upstream,
> but don't think this should hold back the package.
>
I think we can bundle the patch until it/if gets accepts at all by
upstream.
next prev parent reply other threads:[~2016-10-22 11:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-18 8:04 [PATCH] gnu: Add whois ng0
2016-10-18 8:04 ` ng0
2016-10-18 13:03 ` Marius Bakke
2016-10-18 13:50 ` ng0
2016-10-18 15:10 ` Marius Bakke
2016-10-22 11:04 ` ng0 [this message]
2016-10-22 11:24 ` ng0
2016-10-22 16:09 ` Marius Bakke
2016-10-22 18:57 ` ng0
2016-10-22 19:21 ` Marius Bakke
2016-10-22 19:28 ` ng0
2016-10-24 16:52 ` Marius Bakke
2017-01-04 17:41 ` ng0
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760okve4a.fsf@we.make.ritual.n0.is \
--to=ng0@we.make.ritual.n0.is \
--cc=guix-devel@gnu.org \
--cc=mbakke@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.