all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Roel Janssen <roel@gnu.org>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: guix-devel@gnu.org, Alex Kost <alezost@gmail.com>,
	Federico Beffa <beffa@fbengineering.ch>
Subject: Re: [PATCH 2/2] gnu: Add emacs-org-trello.
Date: Fri, 28 Oct 2016 19:52:18 +0200	[thread overview]
Message-ID: <8760ocwect.fsf@gnu.org> (raw)
In-Reply-To: <87twbwjuta.fsf@elephly.net>


Ricardo Wurmus writes:

> Roel Janssen <roel@gnu.org> writes:
>
>> So, the only proper way to do it, is to manually add a test phase in
>> each package definition.  But then we still have to add a lot of
>> dependencies that are only needed to run the tests, and even then the
>> tests don't say much..  In the case of this package, the test functions
>> can't run because they use functions that aren't loaded yet, which
>> results in failures of the tests (while the package works just fine).
>>
>> Could I therefore, please, go ahead and push the patch without the
>> additional inputs for running tests?
>
> Yes, please do!  I was just curious.  Sorry for delaying this!
>
> ~~ Ricardo

Pushed in 36e5d1038 and ed8bc028f.

Thanks!

  reply	other threads:[~2016-10-28 17:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-25 21:09 [PATCH 2/2] gnu: Add emacs-org-trello Roel Janssen
2016-10-25 21:26 ` Ricardo Wurmus
2016-10-27  8:31   ` Roel Janssen
2016-10-27 14:09     ` Ricardo Wurmus
2016-10-27 18:22       ` Alex Kost
2016-10-27 18:48         ` Ricardo Wurmus
2016-10-28  9:30           ` Alex Kost
2016-10-28 13:03             ` Roel Janssen
2016-10-28 16:35               ` Ricardo Wurmus
2016-10-28 17:52                 ` Roel Janssen [this message]
2016-10-28 16:21             ` Federico Beffa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8760ocwect.fsf@gnu.org \
    --to=roel@gnu.org \
    --cc=alezost@gmail.com \
    --cc=beffa@fbengineering.ch \
    --cc=guix-devel@gnu.org \
    --cc=rekado@elephly.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.