From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roel Janssen Subject: Re: [PATCH] gnu: Add qtwebkit. Date: Wed, 02 Nov 2016 13:35:21 +0100 Message-ID: <8760o6cb5i.fsf@gnu.org> References: <20161028.112601.737405433041352600.post@thomasdanckaert.be> <8737jgh6tr.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:49214) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c1uk0-0000um-1M for guix-devel@gnu.org; Wed, 02 Nov 2016 08:34:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c1ujw-0006dE-Sj for guix-devel@gnu.org; Wed, 02 Nov 2016 08:34:04 -0400 In-reply-to: <8737jgh6tr.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Thomas Danckaert Cc: guix-devel@gnu.org Roel Janssen writes: > Thomas Danckaert writes: > >> Hi, >> >> this patch adds QtWebKit 5.7 as a separate package (hopefully this will reduce security concerns: only packages which really need QtWebKit will include it). >> >> QtWebKit is not officially supported anymore as of Qt 5.6, so this is a “community release” (not exactly sure what that entails, or if this includes any updates at all since the Qt 5.5 version). I suppose many projects are switching to Qt WebEngine, and there are some efforts to create an updated version of QtWebKit (https://github.com/annulen/webkit), but in the mean time, this package might help build packages which still rely on the old QtWebKit. >> >> By default, the qmake build system for qtwebkit insists on installing into the same prefix as qtbase, and it seems no command line parameters will change that. The solution I came up with, was to substitute all the necessary paths in the generated Makefiles. This makes the patch a bit lengthy. >> >> I've also attached a minimal example. >> >> Thomas >> QT += widgets >> QT += webkit >> QT += webkitwidgets >> SOURCES = example.cpp >> >> #include >> #include >> >> int main(int argc, char** argv) { >> QApplication app(argc, argv); >> QWebView view; >> view.show(); >> view.setUrl(QUrl("https://www.gnu.org/software/guix")); >> return app.exec(); >> } > > Thanks a lot for this patch. I can confirm it builds fine, yet I have > to test it on some Qt packages that need QtWebkit (Texmaker). I think this patch works fine. Unfortunately for me, it does not fix Texmaker's build because it needs QtWebkitWidgets which is apparently a different thing. Kind regards, Roel Janssen