From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: Re: 01/01: gnu: python-pyopenssl: Disable tests. Date: Fri, 16 Dec 2016 14:21:47 +0100 Message-ID: <8760mkrous.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> References: <20161214173803.7999.79849@vcs.savannah.gnu.org> <20161214173804.3FE492201BA@vcs.savannah.gnu.org> <20161215234919.GA14722@jasmine> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:51316) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cHsST-00012L-6l for guix-devel@gnu.org; Fri, 16 Dec 2016 08:21:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cHsSP-0003h3-Vz for guix-devel@gnu.org; Fri, 16 Dec 2016 08:21:57 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:33161) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cHsSP-0003gc-P6 for guix-devel@gnu.org; Fri, 16 Dec 2016 08:21:53 -0500 In-Reply-To: <20161215234919.GA14722@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari , guix-devel@gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Leo Famulari writes: > On Wed, Dec 14, 2016 at 05:38:04PM +0000, Marius Bakke wrote: >> mbakke pushed a commit to branch python-tests >> in repository guix. >>=20 >> commit 30e0229a1713e77dc0397dfb4ee6af4ac6a00443 >> Author: Marius Bakke >> Date: Wed Dec 14 18:34:48 2016 +0100 >>=20 >> gnu: python-pyopenssl: Disable tests. >>=20=20=20=20=20 >> * gnu/packages/python.scm (python-pyopenssl, python2-pyopenssl)[argu= ments]: >> Set #:tests? #f. >> [native-inputs]: Add python-pytest. >> --- >> gnu/packages/python.scm | 5 +++++ >> 1 file changed, 5 insertions(+) >>=20 >> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm >> index cd6ed1c..ebe0194 100644 >> --- a/gnu/packages/python.scm >> +++ b/gnu/packages/python.scm >> @@ -6585,11 +6585,16 @@ message digests and key derivation functions.") >> (base32 >> "0vji4yrfshs15xpczbhzhasnjrwcarsqg87n98ixnyafnyxs6ybp")))) >> (build-system python-build-system) >> + (arguments >> + ;; FIXME: Some tests fail with "NameError: name 'long' is not defi= ned". >> + '(#:tests? #f)) > > Do you think this indicates a real problem? Or is the issue limited to > the tests? I dug a bit further into this, and the problem is likely that PYTHONPATH is incomplete at test time. Moving 'check after 'install and adding a proper PYTHONPATH seems to work, but now I ran into a test needing network access. https://github.com/pyca/pyopenssl/blob/16.2.0/tests/test_ssl.py#L1186 I'll prepare a patch to remove that test entirely, unless someone knows a clever way to check for network access and conditionally skip it (which I'm sure upstream would be happy to accept). --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlhT6mwACgkQoqBt8qM6 VPoCZwgAxz69JlkAyyy4SY5h/3Is07hBTD7Zyn95SD5B8UWNAzBAIscW5PyZVvVp x39fXYwfgquFUzdzCuAvjN37LlGMHULg9M11Bvjc8jQz0TrDK1GxlFffnbWLS2N6 eU0uZxqIPEKCdWeEG4EsdRX1XrblfONmdTtMNew+2+Th9ETLk2+rcWEuW+PouaWO XcGvUMNN+qN6m1BhTIhrOXaEVglfjwBgnbIY0XTAoXynpxIHruJvFh7oor2ssQS+ 3c+yN+IhsqX3bWjAIe0nEaCoCN1OfS/LhPsgyu3/lyj6+f0YZEoKjUrCgPT6urTZ fSf3C8491n8ANeNMdF0fPOjyEfmYQQ== =k44M -----END PGP SIGNATURE----- --=-=-=--