all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Marius Bakke <mbakke@fastmail.com>
To: Leo Famulari <leo@famulari.name>, guix-devel@gnu.org
Subject: Re: 01/01: gnu: python-pyopenssl: Disable tests.
Date: Fri, 16 Dec 2016 14:21:47 +0100	[thread overview]
Message-ID: <8760mkrous.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <20161215234919.GA14722@jasmine>

[-- Attachment #1: Type: text/plain, Size: 1738 bytes --]

Leo Famulari <leo@famulari.name> writes:

> On Wed, Dec 14, 2016 at 05:38:04PM +0000, Marius Bakke wrote:
>> mbakke pushed a commit to branch python-tests
>> in repository guix.
>> 
>> commit 30e0229a1713e77dc0397dfb4ee6af4ac6a00443
>> Author: Marius Bakke <mbakke@fastmail.com>
>> Date:   Wed Dec 14 18:34:48 2016 +0100
>> 
>>     gnu: python-pyopenssl: Disable tests.
>>     
>>     * gnu/packages/python.scm (python-pyopenssl, python2-pyopenssl)[arguments]:
>>     Set #:tests? #f.
>>     [native-inputs]: Add python-pytest.
>> ---
>>  gnu/packages/python.scm |    5 +++++
>>  1 file changed, 5 insertions(+)
>> 
>> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
>> index cd6ed1c..ebe0194 100644
>> --- a/gnu/packages/python.scm
>> +++ b/gnu/packages/python.scm
>> @@ -6585,11 +6585,16 @@ message digests and key derivation functions.")
>>          (base32
>>           "0vji4yrfshs15xpczbhzhasnjrwcarsqg87n98ixnyafnyxs6ybp"))))
>>      (build-system python-build-system)
>> +    (arguments
>> +     ;; FIXME: Some tests fail with "NameError: name 'long' is not defined".
>> +     '(#:tests? #f))
>
> Do you think this indicates a real problem? Or is the issue limited to
> the tests?

I dug a bit further into this, and the problem is likely that PYTHONPATH
is incomplete at test time. Moving 'check after 'install and adding a
proper PYTHONPATH seems to work, but now I ran into a test needing
network access.

https://github.com/pyca/pyopenssl/blob/16.2.0/tests/test_ssl.py#L1186

I'll prepare a patch to remove that test entirely, unless someone knows
a clever way to check for network access and conditionally skip it
(which I'm sure upstream would be happy to accept).

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

  reply	other threads:[~2016-12-16 13:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20161214173803.7999.79849@vcs.savannah.gnu.org>
     [not found] ` <20161214173804.3FE492201BA@vcs.savannah.gnu.org>
2016-12-15 23:49   ` 01/01: gnu: python-pyopenssl: Disable tests Leo Famulari
2016-12-16 13:21     ` Marius Bakke [this message]
2016-12-16 20:20       ` Leo Famulari
2016-12-16 20:22         ` Marius Bakke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8760mkrous.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me \
    --to=mbakke@fastmail.com \
    --cc=guix-devel@gnu.org \
    --cc=leo@famulari.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.