Re: 01/01: gnu: python-pyopenssl: Disable tests.

[Marius Bakke <mbakke@fastmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1738 bytes --]

Leo Famulari <leo@famulari.name> writes:

> On Wed, Dec 14, 2016 at 05:38:04PM +0000, Marius Bakke wrote:
>> mbakke pushed a commit to branch python-tests
>> in repository guix.
>> 
>> commit 30e0229a1713e77dc0397dfb4ee6af4ac6a00443
>> Author: Marius Bakke <mbakke@fastmail.com>
>> Date:   Wed Dec 14 18:34:48 2016 +0100
>> 
>>     gnu: python-pyopenssl: Disable tests.
>>     
>>     * gnu/packages/python.scm (python-pyopenssl, python2-pyopenssl)[arguments]:
>>     Set #:tests? #f.
>>     [native-inputs]: Add python-pytest.
>> ---
>>  gnu/packages/python.scm |    5 +++++
>>  1 file changed, 5 insertions(+)
>> 
>> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
>> index cd6ed1c..ebe0194 100644
>> --- a/gnu/packages/python.scm
>> +++ b/gnu/packages/python.scm
>> @@ -6585,11 +6585,16 @@ message digests and key derivation functions.")
>>          (base32
>>           "0vji4yrfshs15xpczbhzhasnjrwcarsqg87n98ixnyafnyxs6ybp"))))
>>      (build-system python-build-system)
>> +    (arguments
>> +     ;; FIXME: Some tests fail with "NameError: name 'long' is not defined".
>> +     '(#:tests? #f))
>
> Do you think this indicates a real problem? Or is the issue limited to
> the tests?

I dug a bit further into this, and the problem is likely that PYTHONPATH
is incomplete at test time. Moving 'check after 'install and adding a
proper PYTHONPATH seems to work, but now I ran into a test needing
network access.

https://github.com/pyca/pyopenssl/blob/16.2.0/tests/test_ssl.py#L1186

I'll prepare a patch to remove that test entirely, unless someone knows
a clever way to check for network access and conditionally skip it
(which I'm sure upstream would be happy to accept).

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]