From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34611) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dEK4o-0000hX-Jv for guix-patches@gnu.org; Fri, 26 May 2017 14:35:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dEK4k-0003uo-N1 for guix-patches@gnu.org; Fri, 26 May 2017 14:35:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:36888) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dEK4k-0003uB-8k for guix-patches@gnu.org; Fri, 26 May 2017 14:35:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dEK4k-0003Ji-3j for guix-patches@gnu.org; Fri, 26 May 2017 14:35:02 -0400 Subject: bug#27077: [PATCH] gnu: python-xcffib: Update to 0.5.1. Resent-To: guix-patches@gnu.org Resent-Message-ID: From: Marius Bakke In-Reply-To: <1710abf8c15616976d5b79e5e61364ac@openmailbox.org> References: <02de3feec1033d408e8f9e15cebb9c45@openmailbox.org> <87y3tktva1.fsf@fastmail.com> <1710abf8c15616976d5b79e5e61364ac@openmailbox.org> Date: Fri, 26 May 2017 20:34:33 +0200 Message-ID: <8760gntqkm.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: =?UTF-8?Q?Jos=C3=A9?= Miguel =?UTF-8?Q?S=C3=A1nchez_?= =?UTF-8?Q?Garc=C3=ADa?= Cc: 27077-done@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Jos=C3=A9 Miguel S=C3=A1nchez Garc=C3=ADa writes: >> Also, with this patch, "./pre-inst-env guix build python-cairocffi" >> fails to build with an error such as: >>=20 >> OSError: cannot load library 'libxcb.so.1': libxcb.so.1: cannot open >> shared object file: No such file or directory >>=20 >> Can you try to substitute the invocation of "libxcb.so.1" in >> "xcffib/init.py" to use the full store path and see if that helps? > Ok, I fixed it in a separate patch. That was the reason test were > disabled so that fixed them too. It looks like it does not actually run any tests. The check phase ends with: Ran 0 tests in 0.000s=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 OK=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20 phase `check' succeeded after 1.4 seconds Looking in the upstream CI configuration (".travis.yml"), it's going to take some work. Maybe you can give it a go? "cabal" does not work well with Guix at the moment, but I think just getting the "pycheck" make target working would be a good start (just runs "nosetests -v -d"). Regardless, I've applied the patch for now since it fixes a real issue, but left a FIXME and #:tests #f. Also added a #t after the substitute* call since the return value is unspecified. >> Can you change this to use 'pypi-uri' instead? > Any reason why `guix import` doesn't do that by default? I just copied > the output from that command, so I believed it was the way it should > be done. IIRC, 'pypi-uri' was added after the pypi importer was made. Improvements welcome! > Anyway, here you have both patches. Please check the message of the > first one, as I'm not fully used to Guix conventions regarding this. Great. I updated the commit messages of both patches to mention with section of the code is changed as per our usual style ([source], [arguments] etc). Pushed as 8347c12291ca2234dfdee87074e305793d71f787. Closing this bug, but it would be great to get those tests running! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlkodTkACgkQoqBt8qM6 VPpN+Qf/RvGCd4TKgFPjudaCGoF8fGlqpM0yh2lGgiLDDxlPCOc8m7Hw6fGUs7F5 Ljie74fNmyTZKNvMFL75kKAa13i9Zx2yG26ITjDBGDUQzzqXES/xZGBThOqj1/Gu VWWNp7LUkNQnz3Jt+ZMjiIn546C0JZIj1p/Aj7PjhChzNzgm8UITCsPuE7IgkjqM VPoroRSVi6TV9kbgq1R8mwcqRU2Xiv1hRM0b6tDPD3b7nmkNfR6ZAxK9/Ri32ST4 B0uy2SdaFmSNDAU6SWAsyK2wskgfRZoaJw82SJDD70+ErkrhEwSDG26RPLEvJOWG CUKlKUErxz3E7BKeeIqYXQl2nDSfeQ== =Od89 -----END PGP SIGNATURE----- --=-=-=--