bug#27077: [PATCH] gnu: python-xcffib: Update to 0.5.1.

[Marius Bakke <mbakke@fastmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1999 bytes --]

José Miguel Sánchez García <jmi2k@openmailbox.org> writes:

>> Also, with this patch, "./pre-inst-env guix build python-cairocffi"
>> fails to build with an error such as:
>> 
>> OSError: cannot load library 'libxcb.so.1': libxcb.so.1: cannot open
>> shared object file: No such file or directory
>> 
>> Can you try to substitute the invocation of "libxcb.so.1" in
>> "xcffib/init.py" to use the full store path and see if that helps?
> Ok, I fixed it in a separate patch. That was the reason test were
> disabled so that fixed them too.

It looks like it does not actually run any tests. The check phase ends
with:

Ran 0 tests in 0.000s                                      
OK                                                      
phase `check' succeeded after 1.4 seconds

Looking in the upstream CI configuration (".travis.yml"), it's going to
take some work. Maybe you can give it a go? "cabal" does not work well
with Guix at the moment, but I think just getting the "pycheck" make
target working would be a good start (just runs "nosetests -v -d").

Regardless, I've applied the patch for now since it fixes a real issue,
but left a FIXME and #:tests #f. Also added a #t after the substitute*
call since the return value is unspecified.

>> Can you change this to use 'pypi-uri' instead?
> Any reason why `guix import` doesn't do that by default? I just copied
> the output from that command, so I believed it was the way it should
> be done.

IIRC, 'pypi-uri' was added after the pypi importer was made.
Improvements welcome!

> Anyway, here you have both patches. Please check the message of the
> first one, as I'm not fully used to Guix conventions regarding this.

Great. I updated the commit messages of both patches to mention with
section of the code is changed as per our usual style ([source],
[arguments] etc). Pushed as 8347c12291ca2234dfdee87074e305793d71f787.

Closing this bug, but it would be great to get those tests running!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]