From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58671)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1duli2-0007EO-UV
	for guix-patches@gnu.org; Wed, 20 Sep 2017 16:35:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1duli2-0004iN-6f
	for guix-patches@gnu.org; Wed, 20 Sep 2017 16:35:02 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:41904)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1duli2-0004iG-2k
	for guix-patches@gnu.org; Wed, 20 Sep 2017 16:35:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1duli1-0003fZ-Sq
	for guix-patches@gnu.org; Wed, 20 Sep 2017 16:35:01 -0400
Subject: [bug#28378] [PATCH] gnu: Add heimdall.
Resent-Message-ID: <handler.28378.B28378.150593967414065@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20170906223653.15420-1-dannym@scratchpost.org>
	<87shfzylum.fsf@gnu.org> <20170920220902.21333ec3@lepiller.eu>
Date: Wed, 20 Sep 2017 22:34:23 +0200
In-Reply-To: <20170920220902.21333ec3@lepiller.eu> (Julien Lepiller's message
	of "Wed, 20 Sep 2017 22:09:02 +0200")
Message-ID: <8760cdrtww.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Julien Lepiller <julien@lepiller.eu>
Cc: 28378@debbugs.gnu.org

Hi Julien,

Julien Lepiller <julien@lepiller.eu> skribis:

> From 0cd2378f5aa2626f8118d607a6b3558c212d80ec Mon Sep 17 00:00:00 2001
> From: Julien Lepiller <julien@lepiller.eu>
> Date: Tue, 29 Aug 2017 23:54:16 +0200
> Subject: [PATCH] gnu: Add heimdall.
>
> * gnu/packages/flashing-tools.scm (heimdall): New variable.
>
> Co-Authored-By: Danny Milosavljevic <dannym@scratchpost.org>

It LGTM.  I don=E2=80=99t see why libpit.a is needed, but I=E2=80=99ll let =
you decide.  :-)

> +    (build-system cmake-build-system)
> +    (arguments
> +     `(#:configure-flags '("-DCMAKE_BUILD_TYPE=3DRelease")

Why not keep the default =E2=80=9CRelWithDebInfo=E2=80=9D?

Thanks!

Ludo=E2=80=99.