From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58935) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1emjD3-0002BQ-94 for guix-patches@gnu.org; Fri, 16 Feb 2018 11:50:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1emjD0-0000n5-74 for guix-patches@gnu.org; Fri, 16 Feb 2018 11:50:05 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:39237) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1emjD0-0000mt-33 for guix-patches@gnu.org; Fri, 16 Feb 2018 11:50:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1emjCz-0008EB-ON for guix-patches@gnu.org; Fri, 16 Feb 2018 11:50:01 -0500 Subject: [bug#30340] [PATCH 1/6] gnu: qtbase: Use the store paths for other packages and dynamically loaded libs. Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20180203192212.29173-1-h.goebel@crazy-compilers.com> <20180203192505.29516-1-h.goebel@crazy-compilers.com> <87k1voixl0.fsf@fastmail.com> <180a63cd-4939-4752-f3ba-dc7534465cc9@crazy-compilers.com> <87sha4wlot.fsf@fastmail.com> <23d7b29f-00ad-b167-c8ba-a8f5386f51e2@crazy-compilers.com> Date: Fri, 16 Feb 2018 17:49:33 +0100 In-Reply-To: <23d7b29f-00ad-b167-c8ba-a8f5386f51e2@crazy-compilers.com> (Hartmut Goebel's message of "Fri, 16 Feb 2018 17:18:30 +0100") Message-ID: <87606wnale.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Hartmut Goebel Cc: 30340@debbugs.gnu.org Hartmut Goebel skribis: > Am 13.02.2018 um 23:48 schrieb Marius Bakke: >>> I do not care about the comments, but FMPOV it is important to document >>> somehow in the code or in the commits that all patches as of 2018-01-19 >>> have been considered. an alternative would be to group these few commits >>> into a (very short) branch and documenting the fact in the merge-commit. >>> >>> WDYT? >> I don't think the comments are all that useful. They only add noise in >> the commit log and the code -- since we have a working and up-to-date >> Qt, it is implied that we don't need anything more from NixOS or >> elsewhere. >> > @Ludo: What's you opinion on this? (See also > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D30340#62) I don=E2=80=99t have much to add. It=E2=80=99s good to add comments for th= ings that aren=E2=80=99t obvious by looking at the =E2=80=98substitute*=E2=80=99 sequ= ences, but for obvious things it=E2=80=99s =E2=80=9Cnoise=E2=80=9D indeed. At any rate, this shouldn=E2=80=99t hold the patches back. Thanks, Ludo=E2=80=99.