From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41301) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1evMs3-0004CP-0W for guix-patches@gnu.org; Mon, 12 Mar 2018 08:48:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1evMry-0004cf-3d for guix-patches@gnu.org; Mon, 12 Mar 2018 08:48:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:48203) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1evMrx-0004bq-Vs for guix-patches@gnu.org; Mon, 12 Mar 2018 08:48:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1evMrx-0003DC-Lx for guix-patches@gnu.org; Mon, 12 Mar 2018 08:48:01 -0400 Subject: [bug#30761] [PATCH staging 1/9] gnu: meson: Don't wrap the meson executable. Resent-Message-ID: From: Marius Bakke In-Reply-To: <87vae2tfxy.fsf@gnu.org> References: <20180309180914.22752-1-mbakke@fastmail.com> <20180309181108.22888-1-mbakke@fastmail.com> <87vae2tfxy.fsf@gnu.org> Date: Mon, 12 Mar 2018 13:47:31 +0100 Message-ID: <876061jw9o.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 30761@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Hello! > > Marius Bakke skribis: > >> * gnu/packages/build-tools.scm (meson)[arguments]: Delete WRAP-PHASE. >> --- >> gnu/packages/build-tools.scm | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/gnu/packages/build-tools.scm b/gnu/packages/build-tools.scm >> index 2abb44fdb..1ebccca43 100644 >> --- a/gnu/packages/build-tools.scm >> +++ b/gnu/packages/build-tools.scm >> @@ -81,6 +81,11 @@ makes a few sacrifices to acquire fast full and incre= mental build times.") >> (base32 >> "06r8limj38mv884s5riiz6lpzw37cvhbf9jd0smzcbi7fwmv3yah")= ))) >> (build-system python-build-system) >> + (arguments >> + `(#:phases (modify-phases %standard-phases >> + ;; Meson runs itself through the Python interpreter, = so >> + ;; we cannot use the shell wrapper. >> + (delete 'wrap)))) > > I=E2=80=99m not sure what this means. The =E2=80=98wrap=E2=80=99 phase i= s precisely for things > with #!/=E2=80=A6/python, right? > > What problem does it solve? The problem is that at some point after 0.42 (the current meson-for-build), Meson does the equivalent of `python $(which meson)` at runtime. Which ends up tripping over the shell wrapper. I don't remember exactly where I saw the problem, it could have been with "mesontest" which also resides in "meson/bin". The only downside to deleting the wrapper is that you cannot call meson directly from the store; it works fine as long as PYTHONPATH is set (e.g. in a profile). I'll try to clarify the comment. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlqmduMACgkQoqBt8qM6 VPr+cwgAgTB/8szCLo1BRA6a8Oj2X0O0x7ZC+Be9zJoAZh3u4WJTQewj3hVdqSeK oVQKvm+lHyaXp6nnf1qT6Fbm+eQTVUunP6ise6w7NkFgztNK2ffnuBOx9UHBep2d jwmiv8Nsbc7XCEtrc7pXJeWEgo93fMnzCNCepAYDIGB2103mon/TwiprRy1QDVNH e6Vva6xZHroUx/JBNiuEmHPYX6Y5UofAIYcXnPqtrYnadiOX6Wfm+tz8eUfMBo3I B5rptJrjavykKaHgWJQSrfhn1qYOB0Qf+EBQq2gfnEqWlk8YW4y1LfOxDZF0BQIp K1YD0+4aWqDSZJ/Gtql904liZ9ORwA== =Tpfj -----END PGP SIGNATURE----- --=-=-=--