From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56509) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1evnsD-0003Kh-T9 for guix-patches@gnu.org; Tue, 13 Mar 2018 13:38:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1evnsB-0001oB-5K for guix-patches@gnu.org; Tue, 13 Mar 2018 13:38:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:51899) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1evnsB-0001ny-0q for guix-patches@gnu.org; Tue, 13 Mar 2018 13:38:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1evnsA-0008FG-LF for guix-patches@gnu.org; Tue, 13 Mar 2018 13:38:02 -0400 Subject: bug#30701: [PATCH 1/3] services: Rework the PostgreSQL config file to use a record type. Resent-To: guix-patches@gnu.org Resent-Message-ID: References: <87po4jpsgc.fsf@cbaines.net> <20180305193719.28652-1-mail@cbaines.net> <87fu5eyzpe.fsf@lassieur.org> From: Christopher Baines In-reply-to: <87fu5eyzpe.fsf@lassieur.org> Date: Tue, 13 Mar 2018 17:37:30 +0000 Message-ID: <87605z27xh.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur Cc: 30701-done@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Sorry, I made some changes, and merged these patches on the weekend, but I forgot to reply. Cl=C3=A9ment Lassieur writes: > Christopher Baines writes: > >> For the default config file representation. This makes it possible to mo= re >> easily change the configuration file, and have dynamic content. In parti= cular, >> I'm looking at adding a pid file location to the config file. > > ^ > Could you please remove this last sentence (with the pid file)? Done. >> * gnu/services/databases.scm (): New record type. >> (%default-postgres-config): Remove this, it's been replaced by the >> configuration file. >> (): Alter the default for the config file fiel= d. >> (postgresql-service): Alter the default value for the config-file parame= ter. >> --- >> gnu/services/databases.scm | 86 +++++++++++++++++++++++++++++++++++----= ------- >> 1 file changed, 66 insertions(+), 20 deletions(-) >> >> diff --git a/gnu/services/databases.scm b/gnu/services/databases.scm >> index 3ca8f471f..f7d5fffd0 100644 >> --- a/gnu/services/databases.scm >> +++ b/gnu/services/databases.scm >> @@ -26,11 +26,20 @@ >> #:use-module (gnu system shadow) >> #:use-module (gnu packages admin) >> #:use-module (gnu packages databases) >> + #:use-module (guix store) > > I don't think (guix store) is used. Is it? It wasn't, I've removed it. >> #:use-module (guix modules) >> #:use-module (guix records) >> #:use-module (guix gexp) > > ... > >> + `(("log_destination" ,@(with-single-quotes log-destination)) >> + ("hba_file" ,@(with-single-quotes hba-file)) >> + ("ident_file" ,@(with-single-quotes ident-file)) > ^ > Could you please use a shorter name? Like "enclose", so that we won't > go over 80 columns too easily :-). I went with quote' as I think that works well. > Apart from those small things, the three patches LGTM. Thank you > again! Thanks for taking a look and for your comments :) Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlqoDFpfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XcKBBAAmojnwgpIzO3XdgVSVsHzBvYtTKGOeK7+Ez20ILVG4b6h9FGyKQOt91fY rC1Dflp7ZnyA1PUtDU7NW/YZBI8mC0mPjEiRQJJUSpHQ3hwXIHahQfuwEVeMXhqn t/f/ZelfKyYHAzP7fla44UyV0wxGxtYbaevoAIsRzf1R0W3UmLN/TEiRxrUpVPIp g+zvUiyi3H4XYJvZ4L+NZx7C0KRgX6YO4fyNnABJ1qmvQy6y1XqPlZB6En3wIGEN PgDB7vUDCGg91UIM2FgrlbwdI24g+5gOfYALw+QujXgCOQCW+x5F2S5SVpNPZegR jcxnMOw8Faqb3ObVRyRb56cjBsbykZWclWS2ozx8LeepvHJAXqmQB8ra9Tv0LTm6 731N3A8VsUc/LCfpXh1ixEZ2h86bYQ8e8G5ayY4vc9t+ydxgH9fPKywk2XUBRbd3 WsgdWk/U8Z/ElSxc7iXay2M/IADr/BeeymcQKSQeXr836caW/LsZaKsUsBCkgC1N lu6QnNVnQpamId6/VLbVdpw4RHshBSOm8sWEiiM0mbPzzGFlxzsspcTdO+liCYcD mg85GejF93o44epBbplVFSSO9QU+zyNgGgQTBdGUSghEZSaosBSmzMzUZdXfqaYG FrvWll/bayreQ8gvFEr4k/IchJ1jI/SpESAmbcNN3rzIHvMIs+c= =kdPb -----END PGP SIGNATURE----- --=-=-=--