From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33140) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fJJxq-0000GV-Bg for guix-patches@gnu.org; Thu, 17 May 2018 10:33:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fJJxm-0000Cf-3U for guix-patches@gnu.org; Thu, 17 May 2018 10:33:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:59024) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fJJxm-0000CH-02 for guix-patches@gnu.org; Thu, 17 May 2018 10:33:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fJJxl-00005D-N8 for guix-patches@gnu.org; Thu, 17 May 2018 10:33:01 -0400 Subject: [bug#30925] [PATCH] gnu: Add emacs-puppet-mode. Resent-Message-ID: References: <20180324155920.970-1-mail@cbaines.net> <87370mk9j6.fsf@fastmail.com> From: Christopher Baines In-reply-to: <87370mk9j6.fsf@fastmail.com> Date: Thu, 17 May 2018 15:32:10 +0100 Message-ID: <87603mgxp1.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Marius Bakke Cc: 30925@debbugs.gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Marius Bakke writes: > Christopher Baines writes: > >> * gnu/packages/emacs.scm (emacs-puppet-mode): New variable. > > [...] >=20=20=20 >> +(define-public emacs-puppet-mode >> + (let ((commit "b3ed5057166a4f49dfa9be638523a348b55a2fd2") >> + (revision "1")) >> + (package >> + (name "emacs-puppet-mode") >> + (version (git-version "0.3" revision commit)) > > Maybe mention why we can't take the 0.3 tag? > >> + (source >> + (origin >> + (method url-fetch) >> + (uri (string-append >> + "https://raw.githubusercontent.com/voxpupuli/puppet-mode= /" >> + commit "/puppet-mode.el")) > > It would be nice to install the README too, but no strong opinion. > >> + (sha256 >> + (base32 >> + "1indycxawsl0p2aqqg754f6735q3cmah9vd886rpn0ncc3ipi1xm")))) >> + (build-system emacs-build-system) >> + (home-page "https://github.com/voxpupuli/puppet-mode") >> + (synopsis "Emacs major mode for the Puppet configuration language= ") >> + (description >> + "This package provides support for the Puppet configuration lang= uage, >> +including syntax highlighting, indentation of expressions and statement= s, >> +linting of manifests and integration with Puppet Debugger.") >> + (license license:gpl3+)))) > > Perhaps mention in a comment that it includes ASL code, as mentioned in > puppet-mode.el. Hey Marius, Thanks for taking a look at this. I don't follow about the ASL code through, what's that? Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlr9kmpfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9Xdtuw/8CLHhZXVYWrxf/SP5HBvNLj1/QBd4t7vDBH3mFTVWAq6Qiufe2udjgZmB bL4PvYSiPchvVzsZEVXp/suShBqD8w67UMYMqK14m9eq2lM7eNeEBWE0fwQiNNJz Mti5p3WBoYyRMDg7jmi1Wu6ki4VDvstFnTd+rFY2nEbCvkJS/LCtWPYswZy0LYSF jTcrDu9kjl9sjXoDUn2La0ZoTHPIOI7hLvrXBPlgA0oGh6NOEI7HwgFtMFXf0l/8 nCAOH8eapgJpOn/030VPO1Y/I7B1+6Dqb/+74b+L9gHvWLDTCgsH01X4hnX8V4dY X/5N3IjdkmBZORrlC1sgdOxXBJXPiSgrEK56R5bzn9qidrrTkR+bS7RoSk3pWpwF 2WyE1a8RfnSstxAB0vob4ugDOEzU+a7QsUeq3juPAnOLpEktmEeZwhJjzy/LXWRc Nwu3tclbBiGgkGPQx1leE69310xABPbDJIRGuIRdJiQMyjlV09R0pwbTsuErWaZ7 1AgwDPNLIN2OUSp2UQpap/RjEolJHtY7jfZf0LnJQjICEni/FsmOBf2CcD2OidfM XGy6M5+5BP23+R/zcnOK6jWceYhwxlyLQ/U8tidiaGUpVwjJZ3ekvyoylfRFHQSs /huNWdORHnU8bQrwRYxLCtOtl6ljxNMV01b3ByqrWOfGNndaa8U= =ouMb -----END PGP SIGNATURE----- --=-=-=--