From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49232) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fMcLT-0007fJ-Ah for guix-patches@gnu.org; Sat, 26 May 2018 12:47:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fMcLO-0005nS-Cl for guix-patches@gnu.org; Sat, 26 May 2018 12:47:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:41949) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fMcLO-0005nE-8u for guix-patches@gnu.org; Sat, 26 May 2018 12:47:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fMcLN-0005A9-Qi for guix-patches@gnu.org; Sat, 26 May 2018 12:47:01 -0400 Subject: [bug#31599] [PATCH] system: Add u-boot-puma-rk3399. Resent-Message-ID: From: Vagrant Cascadian In-Reply-To: <20180526091953.2e81f92f@scratchpost.org> References: <878t87s71n.fsf@aikidev.net> <20180526091953.2e81f92f@scratchpost.org> Date: Sat, 26 May 2018 09:46:04 -0700 Message-ID: <87603as6ur.fsf@aikidev.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Danny Milosavljevic Cc: 31599@debbugs.gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On 2018-05-26, Danny Milosavljevic wrote: > On Fri, 25 May 2018 15:29:40 -0700 > Vagrant Cascadian wrote: >> [fdtfile u-boot variable needs to manually be set at boot] >>This is likely to be fixed in future u-boot versions. > > Does upstream know about it? A couple hours after I submitted this a patch was submitted upstream that fixes the issue: https://patchwork.ozlabs.org/patch/920785/ >>+ ;; The u-boot.itb is not built by default > > ??? How can that be? Isn't it required for booting? There may be other implementations of boot firmware that consume the various parts of u-boot and don't use u-boot.itb. The Debian u-boot package, for example, does not yet have arm-trusted-frimware or the cortex-m0 firmware available, so it needs to build without it and let the user build the other components and manually construct the u-boot.itb. > I checked the source code - apparently they use mkimage > to build the itb from the its. So now we are using two > "different" mkimage tools. OK I guess - but weird. An earlier patch I did added the tools directory to PATH and used the in-tree mkimage, but I opted for using the mkimage from u-boot-tools when I submitted. Wasn't sure which was better. > All they'd have to do is add=20 > > ALL-y +=3D u-boot.itb > > to the Makefile. Does upstream know about it? I'll bring the issue upstream; it may need to be added conditionally, as not all u-boot targets support generating a u-boot.itb. >>+ (zero? (apply system* "make" `(,@make-flags ,"u-boot.it= b"))))) > > Please use "invoke". It's shorthand for (zero? (system* ...)) but it also > raises an exception on error. > That's easier to maintain (when people add a second invocation they > don't have to add "(and ...)"). > > So here it would be (apply invoke "make" `(,@make-flags ,"u-boot.itb"))))= . Ok. >>(add-after 'unpack 'set-environment >>+ (lambda* (#:key inputs #:allow-other-keys) >>+ ;; Need to copy the firmware into u-boot build >>+ ;; directory. >>+ (copy-file (string-append (assoc-ref inputs "firmware") >>+ "/bl31.bin") "bl31-rk3399.bin= ") >>+ (copy-file (string-append (assoc-ref inputs "firmware-m= 0") >>+ "/rk3399m0.bin") "rk3399m0.bi= n"))) > > Please end this phase with "#t". Please forgive my ignorance, but I'm not sure where it belongs or even why... just a rank beginner with this. :) >>+ (version (string-append "1.3-" revision "." (string-take commit 7)= )) > > Please use (git-version "1.3" revision commit) instead of=20 > > (string-append "1.3-" revision "." (string-take commit 7)) Will do. > Sometimes the indentation you used is slightly off, like this: > > `((foo) > (bar)) > > It should be > > `((foo) > (bar)) Will try to sort those out... Thanks for the review! live well, vagrant --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEcDardHbDotegGFCHt4uC1IFLkbYFAlsJj0wACgkQt4uC1IFL kbbheQ//TB/pae0t9Jb5A0mUqMPk+jHXly2Foi1ryhPfDbrNvZKf3Ya3QbJv/05I RFYgpt2dlcgB1a+lKsjHqx6z/ed6MsvY6UkuaGJDOucurtrih1arodYeqTgP99la /3mcuL/DHtu3GOHS5J8EgxCT3pqodknwwEUS9HitLVo4/IRaSHTF1174Tcq4l8DR O9vYa+i2/S/pJJHvn3vMQw5YBi73056DtisiqpVVYg8In1TWJSmtUjJjFQKaKtNy q4s4Kzx+BFi3DuegpGgtJHZ4nRpIrNZMGh6wyGOTgl8zxZUr+wrglAYr/CrCDlMD +WvgHTtGlrBu2Zt1ObWApDXuwooj3qF/z5f5R4WCTx+g6sMhLYM57Mgjkbo0X/ai 0v4XvS+HA80zDDsigPh/tA0c2etiDxA3dwA9uJp7EDJf1Bq+tFuPEtSC6Qi9RMbb AcHd/nV8DrPjDTLxZjL36xe9bRp+yD/gH+S9gfY6OJ5w2riVTxO3kS6FPzEA08JS Ngwd12KymZqrkDdgqye9OfP+avnubVw0L04ixUVsDBeForFJewIL086F7NlLRg0c J7xjAMMB9cmLFEUGYnvDamg4gvAm2oYZAZisW8nj6ufZfz+i9kt+d9SaqqS77EHK nhqPiI4eA+PSFCodAENnqj8PpzDySxgFbPWpFP6OGUiL8SFgRWs= =dt2V -----END PGP SIGNATURE----- --=-=-=--