From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark H Weaver <mhw@netris.org>
Subject: bug#31974: If a phase returns #f, a warning is issued,
	but the build continues
Date: Fri, 03 Aug 2018 23:23:52 -0400
Message-ID: <87600qstkn.fsf@netris.org>
References: <87efgu8clc.fsf@netris.org>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59835)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1flnCg-0004kS-BL
	for bug-guix@gnu.org; Fri, 03 Aug 2018 23:26:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1flnCc-00061R-CL
	for bug-guix@gnu.org; Fri, 03 Aug 2018 23:26:06 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:35331)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1flnCc-00061G-7d
	for bug-guix@gnu.org; Fri, 03 Aug 2018 23:26:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1flnCb-0006f9-VC
	for bug-guix@gnu.org; Fri, 03 Aug 2018 23:26:01 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.31974.B31974.153335311725557@debbugs.gnu.org>
In-Reply-To: <87efgu8clc.fsf@netris.org> (Mark H. Weaver's message of "Mon, 25
	Jun 2018 23:13:03 -0400")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: 31974@debbugs.gnu.org

Mark H Weaver <mhw@netris.org> writes:

> I just noticed that I made a mistake in commit
> d8a3b1b9e847d4a44d2695f95af77170d4d2788f, which changed 'gnu-build' in
> (guix build gnu-build-system) to issue a warning if a phase returns a
> value other than #t.
>
> The result is that if a phase returns a value other than #t, a warning
> is issued, but the build nonetheless continues to the next phase, and
> the build could ultimately "succeed" even some phases returned #f.
>
> In other words, the return values of phases are effectively ignored,
> except for the warning, so the only way to cause a build with phases to
> fail is to raise an exception.

This should be fixed by commit 82230603ce06de7aa3e4aef2fa093a6dbf0ef8df
in core-updates.

      Mark