[bug#32617] [PATCH] gnu: libjpeg: Update description.

[bug#32617] [PATCH] gnu: libjpeg: Update description.

[Maxim Cournoyer]

[-- Attachment #1: Type: text/plain, Size: 123 bytes --]

Hello,

This should help people like me that failed finding which of our package
provided `jpegtran' :)

Thank you,

Maxim

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-libjpeg-Update-description.patch --]
[-- Type: text/x-patch, Size: 1320 bytes --]

From 188244b597f7f351cdefe0f50f67b463ceab847f Mon Sep 17 00:00:00 2001
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Date: Sun, 2 Sep 2018 17:49:51 -0400
Subject: [PATCH] gnu: libjpeg: Update description.

* gnu/packages/image.scm (libjpeg): Add the list of the programs it provides.
---
 gnu/packages/image.scm | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/image.scm b/gnu/packages/image.scm
index 81d22ed42..c49bf4bf9 100644
--- a/gnu/packages/image.scm
+++ b/gnu/packages/image.scm
@@ -266,8 +266,16 @@ files.  It can compress them as much as 40% losslessly.")
     "Libjpeg implements JPEG image encoding, decoding, and transcoding.
 JPEG is a standardized compression method for full-color and gray-scale
 images.
-The included programs provide conversion between the JPEG format and
-image files in PBMPLUS PPM/PGM, GIF, BMP, and Targa file formats.")
+It also includes programs that provide conversion between the JPEG format and
+image files in PBMPLUS PPM/PGM, GIF, BMP, and Targa file formats, as well as
+lossless JPEG manipulations such as rotation, scaling or cropping:
+@enumerate
+@item cjpeg
+@item djpeg
+@item jpegtran
+@item rdjpgcom
+@item wrjpgcom
+@end enumerate")
    (license license:ijg)
    (home-page "http://www.ijg.org/")))
 
-- 
2.18.0

[bug#32617] [PATCH] gnu: libjpeg: Update description.

[Ludovic Courtès]

Hello!

Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:

> This should help people like me that failed finding which of our package
> provided `jpegtran' :)

Heheh.  :-)

>>From 188244b597f7f351cdefe0f50f67b463ceab847f Mon Sep 17 00:00:00 2001
> From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
> Date: Sun, 2 Sep 2018 17:49:51 -0400
> Subject: [PATCH] gnu: libjpeg: Update description.
>
> * gnu/packages/image.scm (libjpeg): Add the list of the programs it provides.

[...]

> +@item cjpeg
> +@item djpeg
> +@item jpegtran
> +@item rdjpgcom
> +@item wrjpgcom

Nitpicking: maybe write:

  @item @command{cjpeg};
  …
  @item @command{wrjpgcom}.

Otherwise LGTM!

Ludo’.

[bug#32617] [PATCH] gnu: libjpeg: Update description.

[Maxim Cournoyer]

Hi Ludovic!

ludo@gnu.org (Ludovic Courtès) writes:

[...]

>> +@item cjpeg
>> +@item djpeg
>> +@item jpegtran
>> +@item rdjpgcom
>> +@item wrjpgcom
>
> Nitpicking: maybe write:
>
>   @item @command{cjpeg};
>   …
>   @item @command{wrjpgcom}.

I tried this originally, but our linter gently reminded me this was not
supported by our texinfo parser ;).

Thanks for reviewing!

Maxim

[bug#32617] [PATCH] gnu: libjpeg: Update description.

[Ludovic Courtès]

Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:

> ludo@gnu.org (Ludovic Courtès) writes:
>
> [...]
>
>>> +@item cjpeg
>>> +@item djpeg
>>> +@item jpegtran
>>> +@item rdjpgcom
>>> +@item wrjpgcom
>>
>> Nitpicking: maybe write:
>>
>>   @item @command{cjpeg};
>>   …
>>   @item @command{wrjpgcom}.
>
> I tried this originally, but our linter gently reminded me this was not
> supported by our texinfo parser ;).

Oh, I had not noticed that.

Thanks!

Ludo’.

bug#32617: [PATCH] gnu: libjpeg: Update description.

[宋文武]

Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:

> Hello,
>
> This should help people like me that failed finding which of our package
> provided `jpegtran' :)
>

Pushed, thank you!