all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* Proposal: rename sshfs-fuse -> sshfs
@ 2018-11-13  1:22 swedebugia
  2018-11-14  9:47 ` Oleg Pykhalov
  0 siblings, 1 reply; 6+ messages in thread
From: swedebugia @ 2018-11-13  1:22 UTC (permalink / raw)
  To: guix-devel

Reasons:
* shorter is better.
* the project it self names it sshfs.
* there are no other sshfs implementations to my knowledge

-- 
Cheers Swedebugia

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Proposal: rename sshfs-fuse -> sshfs
  2018-11-13  1:22 Proposal: rename sshfs-fuse -> sshfs swedebugia
@ 2018-11-14  9:47 ` Oleg Pykhalov
  2018-11-14 11:41   ` Ricardo Wurmus
  0 siblings, 1 reply; 6+ messages in thread
From: Oleg Pykhalov @ 2018-11-14  9:47 UTC (permalink / raw)
  To: swedebugia; +Cc: guix-devel

[-- Attachment #1: Type: text/plain, Size: 851 bytes --]

Hello,

swedebugia <swedebugia@riseup.net> writes:

> Reasons:
> * shorter is better.

Not always, e.g. as you see we have a policy to prefix package names
like font-dejavu and emacs-guix, but I don't see this in ‘fuse’ case:
--8<---------------cut here---------------start------------->8---
$ guix package -A fuse | awk '{ print $1 }'
enblend-enfuse
fuse
fuse-exfat
libconfuse
python-defusedxml
python-fusepy
python-llfuse
python-llfuse
python2-defusedxml
python2-fusepy
python2-llfuse
sshfs-fuse
unionfs-fuse
unionfs-fuse-static
--8<---------------cut here---------------end--------------->8---

> * the project it self names it sshfs.

It was an “issue” for me to install sshfs by naive typing
‘guix package -i sshfs’ :-)

> * there are no other sshfs implementations to my knowledge

Agree.

Oleg.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Proposal: rename sshfs-fuse -> sshfs
  2018-11-14  9:47 ` Oleg Pykhalov
@ 2018-11-14 11:41   ` Ricardo Wurmus
  2018-11-14 17:25     ` Leo Famulari
  0 siblings, 1 reply; 6+ messages in thread
From: Ricardo Wurmus @ 2018-11-14 11:41 UTC (permalink / raw)
  To: Oleg Pykhalov; +Cc: guix-devel


Hi,

I have no objections to renaming the package, though you’ll need to keep
a definition for “sshfs-fuse” to indicate to users that the package has
been renamed.

--
Ricardo

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Proposal: rename sshfs-fuse -> sshfs
  2018-11-14 11:41   ` Ricardo Wurmus
@ 2018-11-14 17:25     ` Leo Famulari
  2019-01-14 20:12       ` [bug#34079] [PATCH] sshfs rename (Was: Re: Proposal: rename sshfs-fuse -> sshfs) swedebugia
  0 siblings, 1 reply; 6+ messages in thread
From: Leo Famulari @ 2018-11-14 17:25 UTC (permalink / raw)
  To: Ricardo Wurmus; +Cc: guix-devel

[-- Attachment #1: Type: text/plain, Size: 332 bytes --]

On Wed, Nov 14, 2018 at 12:41:59PM +0100, Ricardo Wurmus wrote:
> I have no objections to renaming the package, though you’ll need to keep
> a definition for “sshfs-fuse” to indicate to users that the package has
> been renamed.

Right. See the definition of 'letsencrypt' in (gnu packages tls) for an
example of this.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#34079] [PATCH] sshfs rename (Was: Re: Proposal: rename sshfs-fuse -> sshfs)
  2018-11-14 17:25     ` Leo Famulari
@ 2019-01-14 20:12       ` swedebugia
  2019-01-15 15:49         ` bug#34079: " Leo Famulari
  0 siblings, 1 reply; 6+ messages in thread
From: swedebugia @ 2019-01-14 20:12 UTC (permalink / raw)
  To: Leo Famulari; +Cc: rekado, 34079

[-- Attachment #1: Type: text/plain, Size: 395 bytes --]

Leo Famulari <leo@famulari.name> writes:

> On Wed, Nov 14, 2018 at 12:41:59PM +0100, Ricardo Wurmus wrote:
>> I have no objections to renaming the package, though you’ll need to keep
>> a definition for “sshfs-fuse” to indicate to users that the package has
>> been renamed.
>
> Right. See the definition of 'letsencrypt' in (gnu packages tls) for an
> example of this.

Done.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Rename-sshfs-fuse-to-sshfs.patch --]
[-- Type: text/x-patch, Size: 1272 bytes --]

From 86536694d40eb42e746b55cac5caa98e28946ed1 Mon Sep 17 00:00:00 2001
From: swedebugia <swedebugia@riseup.net>
Date: Mon, 14 Jan 2019 21:03:20 +0100
Subject: [PATCH] gnu: Rename sshfs-fuse to sshfs.

* gnu/packages/linux.scm
  (sshfs-fuse): Mark as superseeded.
  (sshfs): New variable.
---
 gnu/packages/linux.scm | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 4fb85f2f3..4b70694d2 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -1810,9 +1810,9 @@ UnionFS-FUSE additionally supports copy-on-write.")
                #t))))))
     (inputs `(("fuse" ,fuse-static)))))
 
-(define-public sshfs-fuse
+(define-public sshfs
   (package
-    (name "sshfs-fuse")
+    (name "sshfs")
     (version "2.10")
     (source (origin
               (method url-fetch)
@@ -1837,6 +1837,11 @@ up: on the server side there's nothing to do; on the client side mounting the
 file system is as easy as logging into the server with an SSH client.")
     (license license:gpl2+)))
 
+(define-public sshfs-fuse
+  (package (inherit sshfs)
+    (name "sshfs-fuse")
+    (properties `((superseded . ,sshfs)))))
+
 (define-public archivemount
   (package
     (name "archivemount")
-- 
2.19.2


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* bug#34079: [PATCH] sshfs rename (Was: Re: Proposal: rename sshfs-fuse -> sshfs)
  2019-01-14 20:12       ` [bug#34079] [PATCH] sshfs rename (Was: Re: Proposal: rename sshfs-fuse -> sshfs) swedebugia
@ 2019-01-15 15:49         ` Leo Famulari
  0 siblings, 0 replies; 6+ messages in thread
From: Leo Famulari @ 2019-01-15 15:49 UTC (permalink / raw)
  To: 34079-done

[-- Attachment #1: Type: text/plain, Size: 456 bytes --]

On Mon, Jan 14, 2019 at 09:12:52PM +0100, swedebugia wrote:
> From 86536694d40eb42e746b55cac5caa98e28946ed1 Mon Sep 17 00:00:00 2001
> From: swedebugia <swedebugia@riseup.net>
> Date: Mon, 14 Jan 2019 21:03:20 +0100
> Subject: [PATCH] gnu: Rename sshfs-fuse to sshfs.

Thanks!

> * gnu/packages/linux.scm
>   (sshfs-fuse): Mark as superseeded.
>   (sshfs): New variable.

I edited this commit message and pushed as
357b9f9d71464180ca78f58abf3a2810ccb589f3

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2019-01-15 15:50 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-13  1:22 Proposal: rename sshfs-fuse -> sshfs swedebugia
2018-11-14  9:47 ` Oleg Pykhalov
2018-11-14 11:41   ` Ricardo Wurmus
2018-11-14 17:25     ` Leo Famulari
2019-01-14 20:12       ` [bug#34079] [PATCH] sshfs rename (Was: Re: Proposal: rename sshfs-fuse -> sshfs) swedebugia
2019-01-15 15:49         ` bug#34079: " Leo Famulari

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.