From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mathieu Othacehe Subject: Re: Merging =?utf-8?Q?=E2=80=98wip-newt-installer=E2=80=99?= in master? Date: Thu, 22 Nov 2018 23:57:38 +0900 Message-ID: <875zwp17od.fsf@gmail.com> References: <87lg6sejwa.fsf@gmail.com> <87wopd88hq.fsf@gmail.com> <877ehcsocq.fsf@gnu.org> <87bm6oxsyf.fsf@gmail.com> <87a7m7yhu5.fsf@gmail.com> <878t1rygfu.fsf@gmail.com> <877ehbydmz.fsf@gmail.com> <87sgzykmyx.fsf@gnu.org> <877eh9245u.fsf@gmail.com> <87efbgx0p0.fsf@gnu.org> <87sgzw5ylb.fsf@gmail.com> <87zhu1cw4p.fsf_-_@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:56430) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gPqQY-0006WE-KI for guix-devel@gnu.org; Thu, 22 Nov 2018 09:57:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gPqQV-0000pa-IT for guix-devel@gnu.org; Thu, 22 Nov 2018 09:57:58 -0500 In-reply-to: <87zhu1cw4p.fsf_-_@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: Guix-devel Hey Ludo, > If you add it to /etc/environment (through > =E2=80=98session-environment-service-type=E2=80=99) it should be fine no? LANG is already part of /etc/environment variables which are loaded by the login program which is PAM aware. The installer isn't PAM aware and it replaces the login program thus LANG is never loaded. > 1. ./configure and (guix self) are adjusted to not build the > installer, at least by default. > > 2. The =E2=80=9Cold=E2=80=9D installation method remains prominently av= ailable, either > by making it clear people can use ctrl-alt-f2 & co. to switch to a > terminal, and maybe adding a message on the welcome page stating > that the installer is =E2=80=9Cbeta=E2=80=9D or something. > > 3. The manual is updated to at least mention the new installer, maybe > not in detail. > > How does that sound? I agree it would be great :), I'm currently focusing on parted support but, I'll shift to the 3 points you described above so that it can be merged on time. > It seems to me that it=E2=80=99s OK to push it quickly because it looks p= retty > good already and if it happens to be buggy, people can always use the > old method. Sure, it is a big addition to the codebase, so its important people can start debugging it as soon as possible. Mathieu