From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54062) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gZjl6-0000Xj-2j for guix-patches@gnu.org; Wed, 19 Dec 2018 16:52:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gZjl5-0005hb-3U for guix-patches@gnu.org; Wed, 19 Dec 2018 16:52:03 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:50920) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gZjl4-0005hW-Vd for guix-patches@gnu.org; Wed, 19 Dec 2018 16:52:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gZjl4-0004qH-U0 for guix-patches@gnu.org; Wed, 19 Dec 2018 16:52:02 -0500 Subject: [bug#33802] [PATCH v2] ui: Report profile hooks separately. Resent-Message-ID: From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20181219125632.17532-1-ricardo.wurmus@mdc-berlin.de> <20181219133629.472-1-ricardo.wurmus@mdc-berlin.de> Date: Wed, 19 Dec 2018 22:51:07 +0100 In-Reply-To: <20181219133629.472-1-ricardo.wurmus@mdc-berlin.de> (Ricardo Wurmus's message of "Wed, 19 Dec 2018 14:36:29 +0100") Message-ID: <875zvptcc4.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ricardo Wurmus Cc: 33802@debbugs.gnu.org Hi! Ricardo Wurmus skribis: > * guix/ui.scm (profile-hook-derivation?): New procedure. > (show-what-to-build): Distinguish among BUILD derivations that match > 'profile-hook-derivation?'. Report them separately. > * guix/status.scm (hook-message): New procedure. > (print-build-event): Display profile hooks with readable hook name. > * guix/profiles.scm (info-dir-file, ghc-package-cache-file, > ca-certificate-bundle, glib-schemas, gtk-icon-themes, gtk-im-modules, > xdg-desktop-database, xdg-mime-database, fonts-dir-file, manual-database): > Augment derivation with "type" and "hook" properties. Really cool! > +(define (hook-message hook-type) > + "Return a human-readable string for the profile hook type HOOK-TYPE." > + (match hook-type > + ('info-dir > + "building directory of Info manuals...") > + ('ghc-package-cache > + "building GHC package cache...") > + ('ca-certificate-bundle > + "building CA certificate bundle...") > + ('glib-schemas > + "generating Glib schema cache...") s/Glib/GLib/ :-) > + ('gtk-icon-themes > + "creating GTK+ icon theme cache...") > + ('gtk-im-modules > + "building cache files for GTK+ input methods...") > + ('xdg-desktop-database > + "building XDG desktop file cache...") > + ('xdg-mime-database > + "building XDG MIME database...") > + ('fonts-dir > + "building fonts directory...") > + ('manual-database > + "building database for manual pages...") > + (_ > + (format #f "running profile hook of type '~a'...~%" hook-type)))) You need to wrap each of these strings in (G_ =E2=80=A6), so that xgettext = will find them, and=E2=80=A6 > (define* (print-build-event event old-status status > #:optional (port (current-error-port)) > #:key > @@ -336,6 +363,8 @@ addition to build events." > "applying ~a grafts for ~a..." > count)) > count drv))) > + ('profile-hook > + (format port (info (G_ (hook-message (assq-ref properties 'hoo= k)))))) ^ =E2=80=A6 remove the =E2=80=98G_=E2=80=99 call from here. Thanks! Ludo=E2=80=99.