From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:34306)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1goXbD-0001Qy-T4
	for guix-patches@gnu.org; Tue, 29 Jan 2019 12:55:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1goXbC-00009K-Sx
	for guix-patches@gnu.org; Tue, 29 Jan 2019 12:55:03 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:51512)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1goXbC-000095-Cn
	for guix-patches@gnu.org; Tue, 29 Jan 2019 12:55:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1goXbC-0000j9-4r
	for guix-patches@gnu.org; Tue, 29 Jan 2019 12:55:02 -0500
Subject: [bug#34198] [PATCH 2/2] gnu: Add diffpdf.
Resent-Message-ID: <handler.34198.B34198.15487844742759@debbugs.gnu.org>
References: <20190125164347.17780-1-dannym@scratchpost.org>
	<20190125164802.17853-1-dannym@scratchpost.org>
	<20190125164802.17853-2-dannym@scratchpost.org>
From: Ricardo Wurmus <rekado@elephly.net>
In-reply-to: <20190125164802.17853-2-dannym@scratchpost.org>
Date: Tue, 29 Jan 2019 18:08:45 +0100
Message-ID: <875zu7pf1e.fsf@elephly.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 34198@debbugs.gnu.org


Hi Danny,

> * gnu/packages/pdf.scm (diffpdf): New variable.
[=E2=80=A6]
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'patch-paths
> +           (lambda* (#:key inputs #:allow-other-keys)
> +             (substitute* "diffpdf.pro"
> +              (("-lpoppler-qt4")
> +               (string-append "-L" (assoc-ref inputs "poppler-qt4")
> +                              "/lib -lpoppler-qt4"))

Is this really necessary?  Shouldn=E2=80=99t it be enough to have this dire=
ctory
on LIBRARY_PATH at build time?

> +    (inputs
> +     `(("poppler-qt4" ,poppler-qt4) ; at least 0.20.1
> +       ("qt-4" ,qt-4)))

I was hoping we could get rid of Qt 4 in the near future, because it
doesn=E2=80=99t get security fixes.  Is there no Qt 5 variant?

> +    (home-page "http://www.qtrac.eu/diffpdf-foss.html")
> +    (synopsis "Compare two PDF files")
> +    (description "This package provides a GUI tool to compare two PDF fi=
les.")
> +    (license license:gpl2)))

Looks like GPLv2 or later.

--
Ricardo