From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: bug#37732: mps-youtube propagates util-linux Date: Sun, 03 Nov 2019 17:47:34 +0100 Message-ID: <875zk0q53t.fsf@devup.no> References: <875zks27rf.fsf@GlaDOS.home> <878spo3en3.fsf@devup.no> <87eeyrbqw5.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:52273) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iRJ2p-0006uI-DV for bug-guix@gnu.org; Sun, 03 Nov 2019 11:48:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iRJ2n-0005K9-Vg for bug-guix@gnu.org; Sun, 03 Nov 2019 11:48:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:54383) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iRJ2n-0005K3-Sk for bug-guix@gnu.org; Sun, 03 Nov 2019 11:48:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iRJ2n-0001um-Pd for bug-guix@gnu.org; Sun, 03 Nov 2019 11:48:01 -0500 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <87eeyrbqw5.fsf@gnu.org> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 37732@debbugs.gnu.org, Diego Nicola Barbato --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Hi! > > Marius Bakke skribis: > >> Diego Nicola Barbato writes: >> >>> Hi Guix, >>> >>> An unfortunate chain of propagated-inputs causes 'util-linux' (mount, >>> umount, etc.) to be installed alongside 'mps-youtube': 'mps-youtube' >>> propagates 'python-pygobject', which propagates 'glib', which propagates >>> 'util-linux'. It seems to have been introduced with commit 6c237a2, >>> when 'util-linux' was moved to the propagated-inputs of 'glib'. > > Do we know why this commit moved =E2=80=98util-linux=E2=80=99 to propagat= ed-inputs? > Presumably because of this line in =E2=80=98gio-2.0.pc=E2=80=99, right? > > Requires.private: gmodule-no-export-2.0, zlib, mount >=3D 2.23, libseli= nux I assume so. > If it=E2=80=99s =E2=80=9Cjust=E2=80=9D because of this, I=E2=80=99d say w= e don=E2=80=99t need to propagate > =E2=80=98util-linux=E2=80=99: we only build shared libraries for GLib any= way, so none of > our packages actually use =E2=80=98Requires.private=E2=80=99. If we were= to add > packages requiring it, it=E2=80=99s fine to just add =E2=80=98mount=E2=80= =99 as an explicit > inputs of these packages IMO. > > We could follow the same reasoning for the other things that are > propagated due to their being listed in =E2=80=98Requires.private=E2=80= =99. > > Thoughts? Right. You know, I had forgotten that Requires.private were for static libraries. Thanks for pointing that out. I think quite a few packages propagate Requires.private dependencies without using static libraries. Something to watch out for in the ongoing quest to purge static libraries from Guix. > Moving =E2=80=98util-linux=E2=80=99 back to =E2=80=98inputs=E2=80=99 coul= d perhaps be done on the next > =E2=80=98staging=E2=80=99 or on =E2=80=98core-updates=E2=80=99. util-linux now has 7880 dependent packages, as 'fontconfig' recently started depending on it. So it must go through 'core-updates'. Luckily that branch is slated to start by the end of this month, so the waiting time should not be too long. >> I have attached a WIP patch that fixes this "long term", by moving the >> util-linux libraries to a separate output. It rebuilds 7753 packages >> and is intended for the 'core-updates' branch. >> >> From b9cbe08694ddd8248ac32ce60d5fc40d5c619a54 Mon Sep 17 00:00:00 2001 >> From: Marius Bakke >> Date: Sun, 13 Oct 2019 16:07:44 +0200 >> Subject: [PATCH] gnu: util-linux: Move libraries to separate output. >> >> Fixes . >> Reported by Diego Nicola Barbato . >> >> * gnu/packages/linux.scm (util-linux)[outputs]: Add "dev". >> [arguments]: Update #:configure-flags accordingly. Add phase >> "adjust-bindirs", and rename "move-static-libraries" to "move-libraries", >> while adding a substitution for the .pc files. >> * gnu/packages/fontutils.scm (fontconfig)[propagated-inputs]: Use the "d= ev" >> output of UTIL-LINUX. >> * gnu/packages/glib.scm (glib)[propagated-inputs]: Likewise. > > [...] > >> --- a/gnu/packages/linux.scm >> +++ b/gnu/packages/linux.scm >> @@ -1089,19 +1089,40 @@ providing the system administrator with some hel= p in common tasks.") >> (("build_kill=3Dyes") "build_kill=3Dno")) >> #t)))) >> (build-system gnu-build-system) >> - (outputs '("out" >> - "static")) ; >2 MiB of static .a libraries >> + (outputs '("out" ;6.4 MiB executables and documen= tation >> + "dev" ;8.8 MiB shared libraries, heade= rs and locales >> + "static")) ;2.9 MiB static .a libraries > > Shared libraries are not just for development, so I=E2=80=99d say it shou= ld be > =E2=80=9Clib=E2=80=9D instead, no? Agreed. Will adjust this patch accordingly once I get around to start working on 'core-updates'. :-) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl2/BKYACgkQoqBt8qM6 VPr73Qf/TAyTfm9Nv5zHKQZ6U2NJB9GUIg0lxIKB9HH/O0qzxgS2svJlxR/kzxn/ b+ldgZ5tLkvpGBekV48W+h4endb3bB8OldYbRH3C0esSZA3YuBTjPABulmbRcygi mNN9e/EDCxkDG/zHlDB3u9ZQCdaDZ8IdCjaCCY9neagANd+mcmQ92/S9UPn+AzpG ETM0qserK5DtOr5BIZdbLXy7YfAiZk/FRrlF+w1FxotEpz1FJdiuMOiGjyOr6qBi PpLp+SaKPgcnjZsO5UegYHv6rKRRa2GEtct6J7Oz6RYHeomFG4+sOhzMgGG9poi8 4PQ/WZnS9sgxP5Auf30wOdFWnKPFQg== =7JWZ -----END PGP SIGNATURE----- --=-=-=--